From: Matthew Garrett <mjg59@codon.org.uk>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, amitk@kernel.org,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH] thermal/core: Make 'forced_passive' as obsolete candidate
Date: Sun, 13 Dec 2020 01:11:05 +0000 [thread overview]
Message-ID: <20201213011105.GA21385@codon.org.uk> (raw)
In-Reply-To: <6105a8e5-7590-5ba1-5f2b-aa24bf286150@linaro.org>
On Sun, Dec 13, 2020 at 12:39:26AM +0100, Daniel Lezcano wrote:
> On 12/12/2020 21:08, Matthew Garrett wrote:
> > Anything that provides a trip point that has no active notifications and
> > doesn't provide any information that tells the kernel to poll it.
>
> I'm not able to create a setup as you describe working correctly with
> the forced passive trip point.
>
> The forced passive trip can not be detected as there is no comparison
> with the defined temperature in the thermal_zone_device_update() function.
The logic seems to be in the step_wise thermal governor. I'm not sure
why it would be used in thermal_zone_device_update() - the entire point
is that we don't get updates from the device?
> If my analysis is correct, this 'feature' is broken since years, more
> than 8 years to be exact and nobody complained.
I've no problem with it being removed if there are no users, but in that
case the justification should be rewritten - ACPI table updates aren't a
complete replacement for the functionality offered (and can't be used if
the lockdown LSM is being used in any case).
next prev parent reply other threads:[~2020-12-13 1:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 15:30 [PATCH] thermal/core: Make 'forced_passive' as obsolete candidate Daniel Lezcano
2020-12-11 13:17 ` Daniel Lezcano
2020-12-12 3:50 ` Matthew Garrett
2020-12-12 9:11 ` Daniel Lezcano
2020-12-12 20:08 ` Matthew Garrett
2020-12-12 23:39 ` Daniel Lezcano
2020-12-13 1:11 ` Matthew Garrett [this message]
2020-12-13 11:02 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201213011105.GA21385@codon.org.uk \
--to=mjg59@codon.org.uk \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.