All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: fs/f2fs/compress.c:212 lzo_decompress_pages() warn: should '(1 << 13) << dic->log_cluster_size' be a 64 bit
Date: Sun, 13 Dec 2020 04:57:29 +0800	[thread overview]
Message-ID: <202012130424.mPCef1fb-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2652 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Chao Yu <yuchao0@huawei.com>, Chao Yu <chao@kernel.org>
CC: Jaegeuk Kim <jaegeuk@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7b1b868e1d9156484ccce9bf11122c053de82617
commit: 4c8ff7095bef64fc47e996a938f7d57f9e077da3 f2fs: support data compression
date:   11 months ago
:::::: branch date: 3 hours ago
:::::: commit date: 11 months ago
config: openrisc-randconfig-m031-20201213 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
fs/f2fs/compress.c:212 lzo_decompress_pages() warn: should '(1 << 13) << dic->log_cluster_size' be a 64 bit type?

vim +212 fs/f2fs/compress.c

4c8ff7095bef64f Chao Yu 2019-11-01  198  
4c8ff7095bef64f Chao Yu 2019-11-01  199  static int lzo_decompress_pages(struct decompress_io_ctx *dic)
4c8ff7095bef64f Chao Yu 2019-11-01  200  {
4c8ff7095bef64f Chao Yu 2019-11-01  201  	int ret;
4c8ff7095bef64f Chao Yu 2019-11-01  202  
4c8ff7095bef64f Chao Yu 2019-11-01  203  	ret = lzo1x_decompress_safe(dic->cbuf->cdata, dic->clen,
4c8ff7095bef64f Chao Yu 2019-11-01  204  						dic->rbuf, &dic->rlen);
4c8ff7095bef64f Chao Yu 2019-11-01  205  	if (ret != LZO_E_OK) {
4c8ff7095bef64f Chao Yu 2019-11-01  206  		printk_ratelimited("%sF2FS-fs (%s): lzo decompress failed, ret:%d\n",
4c8ff7095bef64f Chao Yu 2019-11-01  207  				KERN_ERR, F2FS_I_SB(dic->inode)->sb->s_id, ret);
4c8ff7095bef64f Chao Yu 2019-11-01  208  		return -EIO;
4c8ff7095bef64f Chao Yu 2019-11-01  209  	}
4c8ff7095bef64f Chao Yu 2019-11-01  210  
4c8ff7095bef64f Chao Yu 2019-11-01  211  	if (dic->rlen != PAGE_SIZE << dic->log_cluster_size) {
4c8ff7095bef64f Chao Yu 2019-11-01 @212  		printk_ratelimited("%sF2FS-fs (%s): lzo invalid rlen:%zu, "
4c8ff7095bef64f Chao Yu 2019-11-01  213  					"expected:%lu\n", KERN_ERR,
4c8ff7095bef64f Chao Yu 2019-11-01  214  					F2FS_I_SB(dic->inode)->sb->s_id,
4c8ff7095bef64f Chao Yu 2019-11-01  215  					dic->rlen,
4c8ff7095bef64f Chao Yu 2019-11-01  216  					PAGE_SIZE << dic->log_cluster_size);
4c8ff7095bef64f Chao Yu 2019-11-01  217  		return -EIO;
4c8ff7095bef64f Chao Yu 2019-11-01  218  	}
4c8ff7095bef64f Chao Yu 2019-11-01  219  	return 0;
4c8ff7095bef64f Chao Yu 2019-11-01  220  }
4c8ff7095bef64f Chao Yu 2019-11-01  221  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 20982 bytes --]

             reply	other threads:[~2020-12-12 20:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-12 20:57 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-10-10 23:18 fs/f2fs/compress.c:212 lzo_decompress_pages() warn: should '(((1)) << (13)) << dic->log_cluster_size' be a 64 bit kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202012130424.mPCef1fb-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.