All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [PATCH] counter: fix stream_open.cocci warnings
Date: Mon, 14 Dec 2020 09:46:33 +0800	[thread overview]
Message-ID: <20201214014633.GA10092@fe5aba91dd17> (raw)
In-Reply-To: <202012140931.KJccbt92-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1446 bytes --]

CC: kbuild-all(a)lists.01.org
TO: William Breathitt Gray <vilhelm.gray@gmail.com>
CC: David Lechner <david@lechnology.com>
CC: linux-iio(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/counter/counter-chrdev.c:307:8-24: WARNING: counter_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.

Generated by: scripts/coccinelle/api/stream_open.cocci

Fixes: d698926a635b ("counter: Add character device interface")
CC: William Breathitt Gray <vilhelm.gray@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/dlech/linux bone-counter
head:   dc99d06b0f101cff0b3157b1cb49e28e95387c46
commit: d698926a635b0cf342b9b18e04b5f15701834158 [3/21] counter: Add character device interface
:::::: branch date: 2 hours ago
:::::: commit date: 6 hours ago

Please take the patch only if it's a positive warning. Thanks!

 counter-chrdev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/counter/counter-chrdev.c
+++ b/drivers/counter/counter-chrdev.c
@@ -304,7 +304,7 @@ static int counter_chrdev_open(struct in
 	get_device(&counter->dev);
 	filp->private_data = counter;
 
-	return nonseekable_open(inode, filp);
+	return stream_open(inode, filp);
 }
 
 static int counter_chrdev_release(struct inode *inode, struct file *filp)

  reply	other threads:[~2020-12-14  1:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14  1:46 [dlech-linux:bone-counter 3/21] drivers/counter/counter-chrdev.c:307:8-24: WARNING: counter_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open kernel test robot
2020-12-14  1:46 ` kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-10-09  4:45 [linux-next:master 4784/6929] drivers/counter/counter-chrdev.c:394:8-24: " kernel test robot
2021-10-09  4:45 ` [PATCH] counter: fix stream_open.cocci warnings kernel test robot
2021-08-03 16:39 [PATCH v14 10/17] counter: Add character device interface kernel test robot
2021-08-03 16:39 ` [PATCH] counter: fix stream_open.cocci warnings kernel test robot
2021-07-13 13:20 [PATCH v13 10/17] counter: Add character device interface kernel test robot
2021-07-13 13:20 ` [PATCH] counter: fix stream_open.cocci warnings kernel test robot
2020-12-31  2:29 [dlech-linux:bone-counter 3/11] drivers/counter/counter-chrdev.c:319:8-24: WARNING: counter_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open kernel test robot
2020-12-31  2:29 ` [PATCH] counter: fix stream_open.cocci warnings kernel test robot
2020-10-14  5:41 [dlech-linux:bone-counter 3/12] drivers/counter/counter-chrdev.c:294:8-24: WARNING: counter_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open kernel test robot
2020-10-14  5:41 ` [PATCH] counter: fix stream_open.cocci warnings kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201214014633.GA10092@fe5aba91dd17 \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.