From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 63/69] drm/i915/gt: Infrastructure for ring scheduling
Date: Tue, 15 Dec 2020 00:55:44 +0800 [thread overview]
Message-ID: <202012150021.LEU4dWU1-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4563 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20201214100949.11387-63-chris@chris-wilson.co.uk>
References: <20201214100949.11387-63-chris@chris-wilson.co.uk>
TO: Chris Wilson <chris@chris-wilson.co.uk>
TO: intel-gfx(a)lists.freedesktop.org
CC: Chris Wilson <chris@chris-wilson.co.uk>
Hi Chris,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next v5.10 next-20201214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Use-cmpxchg64-for-32b-compatilibity/20201214-181222
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
config: i386-randconfig-m021-20201214 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/i915/gt/intel_ring_scheduler.c:356 __unwind_incomplete_requests() error: uninitialized symbol 'pl'.
vim +/pl +356 drivers/gpu/drm/i915/gt/intel_ring_scheduler.c
38f938d4eb11b84 Chris Wilson 2020-12-14 322
38f938d4eb11b84 Chris Wilson 2020-12-14 323 static struct i915_request *
38f938d4eb11b84 Chris Wilson 2020-12-14 324 __unwind_incomplete_requests(struct intel_engine_cs *engine)
38f938d4eb11b84 Chris Wilson 2020-12-14 325 {
38f938d4eb11b84 Chris Wilson 2020-12-14 326 struct i915_request *rq, *rn, *active = NULL;
38f938d4eb11b84 Chris Wilson 2020-12-14 327 u64 deadline = I915_DEADLINE_NEVER;
38f938d4eb11b84 Chris Wilson 2020-12-14 328 struct list_head *pl;
38f938d4eb11b84 Chris Wilson 2020-12-14 329
38f938d4eb11b84 Chris Wilson 2020-12-14 330 lockdep_assert_held(&engine->active.lock);
38f938d4eb11b84 Chris Wilson 2020-12-14 331
38f938d4eb11b84 Chris Wilson 2020-12-14 332 list_for_each_entry_safe_reverse(rq, rn,
38f938d4eb11b84 Chris Wilson 2020-12-14 333 &engine->active.requests,
38f938d4eb11b84 Chris Wilson 2020-12-14 334 sched.link) {
38f938d4eb11b84 Chris Wilson 2020-12-14 335 if (i915_request_completed(rq)) {
38f938d4eb11b84 Chris Wilson 2020-12-14 336 list_del_init(&rq->sched.link);
38f938d4eb11b84 Chris Wilson 2020-12-14 337 continue;
38f938d4eb11b84 Chris Wilson 2020-12-14 338 }
38f938d4eb11b84 Chris Wilson 2020-12-14 339
38f938d4eb11b84 Chris Wilson 2020-12-14 340 __i915_request_unsubmit(rq);
38f938d4eb11b84 Chris Wilson 2020-12-14 341
38f938d4eb11b84 Chris Wilson 2020-12-14 342 if (i915_request_started(rq)) {
38f938d4eb11b84 Chris Wilson 2020-12-14 343 u64 deadline =
38f938d4eb11b84 Chris Wilson 2020-12-14 344 i915_scheduler_next_virtual_deadline(rq_prio(rq));
38f938d4eb11b84 Chris Wilson 2020-12-14 345 rq->sched.deadline = min(rq_deadline(rq), deadline);
38f938d4eb11b84 Chris Wilson 2020-12-14 346 }
38f938d4eb11b84 Chris Wilson 2020-12-14 347 GEM_BUG_ON(rq_deadline(rq) == I915_DEADLINE_NEVER);
38f938d4eb11b84 Chris Wilson 2020-12-14 348
38f938d4eb11b84 Chris Wilson 2020-12-14 349 if (rq_deadline(rq) != deadline) {
38f938d4eb11b84 Chris Wilson 2020-12-14 350 deadline = rq_deadline(rq);
38f938d4eb11b84 Chris Wilson 2020-12-14 351 pl = i915_sched_lookup_priolist(engine, deadline);
38f938d4eb11b84 Chris Wilson 2020-12-14 352 }
38f938d4eb11b84 Chris Wilson 2020-12-14 353 GEM_BUG_ON(i915_sched_is_idle(&engine->active));
38f938d4eb11b84 Chris Wilson 2020-12-14 354
38f938d4eb11b84 Chris Wilson 2020-12-14 355 GEM_BUG_ON(i915_request_in_priority_queue(rq));
38f938d4eb11b84 Chris Wilson 2020-12-14 @356 list_move(&rq->sched.link, pl);
38f938d4eb11b84 Chris Wilson 2020-12-14 357 set_bit(I915_FENCE_FLAG_PQUEUE, &rq->fence.flags);
38f938d4eb11b84 Chris Wilson 2020-12-14 358
38f938d4eb11b84 Chris Wilson 2020-12-14 359 active = rq;
38f938d4eb11b84 Chris Wilson 2020-12-14 360 }
38f938d4eb11b84 Chris Wilson 2020-12-14 361
38f938d4eb11b84 Chris Wilson 2020-12-14 362 return active;
38f938d4eb11b84 Chris Wilson 2020-12-14 363 }
38f938d4eb11b84 Chris Wilson 2020-12-14 364
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38831 bytes --]
next reply other threads:[~2020-12-14 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 16:55 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-12-14 10:08 [Intel-gfx] [PATCH 01/69] drm/i915: Use cmpxchg64 for 32b compatilibity Chris Wilson
2020-12-14 10:09 ` [Intel-gfx] [PATCH 63/69] drm/i915/gt: Infrastructure for ring scheduling Chris Wilson
2020-12-14 13:29 ` kernel test robot
2020-12-14 13:29 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012150021.LEU4dWU1-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.