From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 918A8C4361B for ; Tue, 15 Dec 2020 08:06:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 321D32228A for ; Tue, 15 Dec 2020 08:06:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726736AbgLOIFq (ORCPT ); Tue, 15 Dec 2020 03:05:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726661AbgLOIFo (ORCPT ); Tue, 15 Dec 2020 03:05:44 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63873C06179C for ; Tue, 15 Dec 2020 00:04:48 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id d13so618456wrc.13 for ; Tue, 15 Dec 2020 00:04:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=MbW/aNPnMI3Tt8o0eStb7kmZYcIkeHTT/zhJDBmp9Po=; b=ERAzFdv3OQLUww5ou7XtAG/8q6kqp/p8+AfwT2MaTB2yzEEM0sYuWSkXTVOI6wIxla Z1Yjv2l6iA3MYW0nu0cUyrHGFWKb99pxy9srXvvZ1M3iX2xkYT7r3sNnHhxiC1weYjA9 wvYgYaIqA7mu88/BRCrDTSyeJKNL466afdLNdIx6FR4CN6bQfTer0bIJXg9T8+y52EbB DSRqiVD0IzrCDqB7hzHC/THJaYeVIDSdjXuwXskAdvI3eXrBjrOaZ6Yl+Lur19glBDkl GACBOOLJ/OX4ZJ3NUBwYU90XTveFA8aiPEvlfURB3O83mTnSqhsRlUK7C+8LJOwyrlPc G0eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=MbW/aNPnMI3Tt8o0eStb7kmZYcIkeHTT/zhJDBmp9Po=; b=DutzvucnxnUHyTX+TPFlfKlczxrOP4MCMrCPWM0KOotYZnGOMdmtUURqW7hbuLzTk0 FsaL6kuYezlHYnBAaTeTj+Zy6X8ZSmCg1bVof1+zVfKIa0N38BTLHK+TG43BgU/5552k BGrqzSK80f+X3tW8mffc1psrwOUNSzCym2j5seRT5srrvGlxDNKmLpG6Dfs3PwVKNTZy 1MgP9LoGvZyNeUR5EkWJY7QUQTWx40Ilo9H/VwHHtM6YbnBcYIggdacC5pIPOT/iJuhz GOOiy0U65rpE/LXrKOtgH/Xjvg35VAV4cdwcqK9Z0AMVaWKO3s4ayqXNR+seY2P8tVHV E2qA== X-Gm-Message-State: AOAM532Fua7l0edSa+AJRFzl2SEGdLelsgLyM0WbzYUMqzfmcO9zmbzH 6JVOyJx3+abwBQDVcnTEcsSsLA== X-Google-Smtp-Source: ABdhPJyBaJVZxusL4+NkX5M1cL9XgJuSWZPi9uRydM6u2Zpl6/+bh4iwRS1pELsgP/ST1fktxMTHnw== X-Received: by 2002:adf:fd41:: with SMTP id h1mr32200972wrs.284.1608019487058; Tue, 15 Dec 2020 00:04:47 -0800 (PST) Received: from dell ([91.110.221.168]) by smtp.gmail.com with ESMTPSA id n12sm38986631wrg.76.2020.12.15.00.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Dec 2020 00:04:46 -0800 (PST) Date: Tue, 15 Dec 2020 08:04:44 +0000 From: Lee Jones To: Daniel Thompson Cc: Zheng Yongjun , jingoohan1@gmail.com, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] backlight: sky81452-backlight: convert comma to semicolon Message-ID: <20201215080444.GK5029@dell> References: <20201214133458.3729-1-zhengyongjun3@huawei.com> <20201214143632.oiqmvpkai7kurc2d@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201214143632.oiqmvpkai7kurc2d@holly.lan> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Mon, 14 Dec 2020, Daniel Thompson wrote: > On Mon, Dec 14, 2020 at 09:34:58PM +0800, Zheng Yongjun wrote: > > Replace a comma between expression statements by a semicolon. > > > > Signed-off-by: Zheng Yongjun > > Weird! I guess it was harmless but still seriously weird ;-) One of these was found in MFD a couple of weeks ago. Yours was exactly my train of thought! One suggestion was to convert all semi-colons to commas and do away with all the curly braces encapsulating if()s, for()s and while()s. Who knew that was even possible? > Reviewed-by: Daniel Thompson > > Thanks! > > > > --- > > drivers/video/backlight/sky81452-backlight.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c > > index 8268ac43d54f..c95e0de7f4e7 100644 > > --- a/drivers/video/backlight/sky81452-backlight.c > > +++ b/drivers/video/backlight/sky81452-backlight.c > > @@ -291,7 +291,7 @@ static int sky81452_bl_probe(struct platform_device *pdev) > > } > > > > memset(&props, 0, sizeof(props)); > > - props.max_brightness = SKY81452_MAX_BRIGHTNESS, > > + props.max_brightness = SKY81452_MAX_BRIGHTNESS; > > name = pdata->name ? pdata->name : SKY81452_DEFAULT_NAME; > > bd = devm_backlight_device_register(dev, name, dev, regmap, > > &sky81452_bl_ops, &props); -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4231FC4361B for ; Tue, 15 Dec 2020 08:04:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBBCF22273 for ; Tue, 15 Dec 2020 08:04:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBBCF22273 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 19B9E891CE; Tue, 15 Dec 2020 08:04:50 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C7CA891CE for ; Tue, 15 Dec 2020 08:04:48 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id y17so18847303wrr.10 for ; Tue, 15 Dec 2020 00:04:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=MbW/aNPnMI3Tt8o0eStb7kmZYcIkeHTT/zhJDBmp9Po=; b=ERAzFdv3OQLUww5ou7XtAG/8q6kqp/p8+AfwT2MaTB2yzEEM0sYuWSkXTVOI6wIxla Z1Yjv2l6iA3MYW0nu0cUyrHGFWKb99pxy9srXvvZ1M3iX2xkYT7r3sNnHhxiC1weYjA9 wvYgYaIqA7mu88/BRCrDTSyeJKNL466afdLNdIx6FR4CN6bQfTer0bIJXg9T8+y52EbB DSRqiVD0IzrCDqB7hzHC/THJaYeVIDSdjXuwXskAdvI3eXrBjrOaZ6Yl+Lur19glBDkl GACBOOLJ/OX4ZJ3NUBwYU90XTveFA8aiPEvlfURB3O83mTnSqhsRlUK7C+8LJOwyrlPc G0eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=MbW/aNPnMI3Tt8o0eStb7kmZYcIkeHTT/zhJDBmp9Po=; b=ncx4b/gMa7/6rrjkpKuY8gT2VjfeME4KJes6O11nPw2ayzQDNH5ppDhC+Qew3dGQam JsPl6AA2pcZoqj5KJRis9i1gJSyRIUKYpXWjmzKFdqiUEMTtZ1dUNsv5OIzSG2/c2IFL KLxLii+vVg72mAIa1GiMLM0SBKchlqYndlDGWiY2yANaFsHMQ/RmqBHAPNs+UuBc/e1O CEycAa2eX6hSe0gwes9nBTGh9TxsBCwsoncOmf8YaK9xgM8OXLohDSxVdRmZW4p1wyjj ZbNLugP6BStotcQNMQCDwlJ9b3VWATmd4fflySS+fl4enXfNVxjU8o3TIuKPGMDxf6WP 09hg== X-Gm-Message-State: AOAM532JOHGVNkBdF8hkQiCablagEAloqEuw5nhjWEgfo8FrpgYKsqgG LKtcEVGhLDEbrxYHF2mN+Q2L8A== X-Google-Smtp-Source: ABdhPJyBaJVZxusL4+NkX5M1cL9XgJuSWZPi9uRydM6u2Zpl6/+bh4iwRS1pELsgP/ST1fktxMTHnw== X-Received: by 2002:adf:fd41:: with SMTP id h1mr32200972wrs.284.1608019487058; Tue, 15 Dec 2020 00:04:47 -0800 (PST) Received: from dell ([91.110.221.168]) by smtp.gmail.com with ESMTPSA id n12sm38986631wrg.76.2020.12.15.00.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Dec 2020 00:04:46 -0800 (PST) Date: Tue, 15 Dec 2020 08:04:44 +0000 From: Lee Jones To: Daniel Thompson Subject: Re: [PATCH -next] backlight: sky81452-backlight: convert comma to semicolon Message-ID: <20201215080444.GK5029@dell> References: <20201214133458.3729-1-zhengyongjun3@huawei.com> <20201214143632.oiqmvpkai7kurc2d@holly.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201214143632.oiqmvpkai7kurc2d@holly.lan> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, b.zolnierkie@samsung.com, jingoohan1@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Zheng Yongjun Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCAxNCBEZWMgMjAyMCwgRGFuaWVsIFRob21wc29uIHdyb3RlOgoKPiBPbiBNb24sIERl YyAxNCwgMjAyMCBhdCAwOTozNDo1OFBNICswODAwLCBaaGVuZyBZb25nanVuIHdyb3RlOgo+ID4g UmVwbGFjZSBhIGNvbW1hIGJldHdlZW4gZXhwcmVzc2lvbiBzdGF0ZW1lbnRzIGJ5IGEgc2VtaWNv bG9uLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBaaGVuZyBZb25nanVuIDx6aGVuZ3lvbmdqdW4z QGh1YXdlaS5jb20+Cj4gCj4gV2VpcmQhIEkgZ3Vlc3MgaXQgd2FzIGhhcm1sZXNzIGJ1dCBzdGls bCBzZXJpb3VzbHkgd2VpcmQgOy0pCgpPbmUgb2YgdGhlc2Ugd2FzIGZvdW5kIGluIE1GRCBhIGNv dXBsZSBvZiB3ZWVrcyBhZ28uCgpZb3VycyB3YXMgZXhhY3RseSBteSB0cmFpbiBvZiB0aG91Z2h0 IQoKT25lIHN1Z2dlc3Rpb24gd2FzIHRvIGNvbnZlcnQgYWxsIHNlbWktY29sb25zIHRvIGNvbW1h cyBhbmQgZG8gYXdheQp3aXRoIGFsbCB0aGUgY3VybHkgYnJhY2VzIGVuY2Fwc3VsYXRpbmcgaWYo KXMsIGZvcigpcyBhbmQgd2hpbGUoKXMuCgpXaG8ga25ldyB0aGF0IHdhcyBldmVuIHBvc3NpYmxl PwoKPiBSZXZpZXdlZC1ieTogRGFuaWVsIFRob21wc29uIDxkYW5pZWwudGhvbXBzb25AbGluYXJv Lm9yZz4KPiAKPiBUaGFua3MhCj4gCj4gCj4gPiAtLS0KPiA+ICBkcml2ZXJzL3ZpZGVvL2JhY2ts aWdodC9za3k4MTQ1Mi1iYWNrbGlnaHQuYyB8IDIgKy0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBp bnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv dmlkZW8vYmFja2xpZ2h0L3NreTgxNDUyLWJhY2tsaWdodC5jIGIvZHJpdmVycy92aWRlby9iYWNr bGlnaHQvc2t5ODE0NTItYmFja2xpZ2h0LmMKPiA+IGluZGV4IDgyNjhhYzQzZDU0Zi4uYzk1ZTBk ZTdmNGU3IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvc2t5ODE0NTIt YmFja2xpZ2h0LmMKPiA+ICsrKyBiL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L3NreTgxNDUyLWJh Y2tsaWdodC5jCj4gPiBAQCAtMjkxLDcgKzI5MSw3IEBAIHN0YXRpYyBpbnQgc2t5ODE0NTJfYmxf cHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiA+ICAJfQo+ID4gIAo+ID4gIAlt ZW1zZXQoJnByb3BzLCAwLCBzaXplb2YocHJvcHMpKTsKPiA+IC0JcHJvcHMubWF4X2JyaWdodG5l c3MgPSBTS1k4MTQ1Ml9NQVhfQlJJR0hUTkVTUywKPiA+ICsJcHJvcHMubWF4X2JyaWdodG5lc3Mg PSBTS1k4MTQ1Ml9NQVhfQlJJR0hUTkVTUzsKPiA+ICAJbmFtZSA9IHBkYXRhLT5uYW1lID8gcGRh dGEtPm5hbWUgOiBTS1k4MTQ1Ml9ERUZBVUxUX05BTUU7Cj4gPiAgCWJkID0gZGV2bV9iYWNrbGln aHRfZGV2aWNlX3JlZ2lzdGVyKGRldiwgbmFtZSwgZGV2LCByZWdtYXAsCj4gPiAgCQkJCQkJJnNr eTgxNDUyX2JsX29wcywgJnByb3BzKTsKCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KU2VuaW9y IFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4g c291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3 aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=