From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E9C8C4361B for ; Tue, 15 Dec 2020 09:18:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01B762222A for ; Tue, 15 Dec 2020 09:18:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726749AbgLOJSO convert rfc822-to-8bit (ORCPT ); Tue, 15 Dec 2020 04:18:14 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:33814 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbgLOJSO (ORCPT ); Tue, 15 Dec 2020 04:18:14 -0500 Received: by mail-ed1-f67.google.com with SMTP id dk8so20224728edb.1; Tue, 15 Dec 2020 01:17:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=dZQENcWGBI+dh1Iu6ct/S1F9dcvge+tYCMiVe0Z+KKs=; b=Gl3ARYbD1g9w0cWv9dVQ9XJIHpDGKNQ0j4eeXeIz+SfssI0chRIEvyXE6c2BlR+Apt j1YQ9wBiPuk11zlNRopJimd4EOkTyRUdhLXnOMI3sP1Z3Wx53f1hrwtrjvXQjvmZvsKm hrXeBEnfYe3ax0kB5YW1AJ3vTQX5oE5z72SiyHUcrmnS/tBGn/wKmnUXljCpjEW5UQk9 MICU5LHxCfbb0/9YXcZVV7bVI8Nzubd2ChfufOJhH+kVjW+vnGeG+8YqJr2slFtCK2UY 0a2tZW9nm0NfMNTTaTiUVj467eHQQve2D1NNY/1WguYFavlajzph/HwJvoVTgQSPB9nS Qu1g== X-Gm-Message-State: AOAM531Cq8OWapRlpwSZh8EuHeenO46ehy+mT1V/tRXc3a8/OGkA+fK6 JM5zk1oz9LpAp/mGAMFdTuc= X-Google-Smtp-Source: ABdhPJzyj6ItHNGHotBpHYpNXSrGsP+uSjgbyPB4ibTWWi2Ly5OfFzTeJj8EKPMmRG6BpZiVFYn+1A== X-Received: by 2002:a50:a692:: with SMTP id e18mr28471961edc.233.1608023852372; Tue, 15 Dec 2020 01:17:32 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id ch30sm18207744edb.8.2020.12.15.01.17.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Dec 2020 01:17:31 -0800 (PST) Date: Tue, 15 Dec 2020 10:17:29 +0100 From: Krzysztof Kozlowski To: Guido =?utf-8?Q?G=C3=BCnther?= Cc: Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Catalin Marinas , Will Deacon , Martin Kepplinger , Angus Ainslie , Bjorn Andersson , Li Yang , Geert Uytterhoeven , Vinod Koul , Anson Huang , Michael Walle , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org Subject: Re: [PATCH 1/4] arm64: defconfig: Enable Librem5 Devkit components Message-ID: <20201215091729.GC29321@kozik-lap> References: <53657bbcaf1292fe58fa8dce497af6734521fb10.1607879709.git.agx@sigxcpu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <53657bbcaf1292fe58fa8dce497af6734521fb10.1607879709.git.agx@sigxcpu.org> Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org On Sun, Dec 13, 2020 at 06:17:11PM +0100, Guido Günther wrote: > This enables > > - touchscreen: CONFIG_TOUCHSCREEN_GOODIX > - charge controller: CONFIG_CHARGER_BQ25890 > - audio codec: CONFIG_SND_SOC_IMX_SGTL5000 > - rtc: CONFIG_RTC_DRV_M41T80 > - magnetometer: CONFIG_IIO_ST_MAGN_3AXIS > - pwm: CONFIG_PWM_IMX27 > - modem codec: CONFIG_SND_SOC_GTM601 > - modem serial: CONFIG_USB_SERIAL_OPTION Do not repeat the contents of the patch. We can easily see which configs you enable. Instead, please name the devices you want to use, not the CONFIG entries. Several drivers actually support multiple devices. Describe also the board you are enabling it for. You wrote only "Librem5", but I am not sure whether this is specific enough. Is it even on NXP i.MX processor? Maybe on something else? This is a generic defconfig so your change will affect everyone. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D3BBC4361B for ; Tue, 15 Dec 2020 09:18:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2ADE522225 for ; Tue, 15 Dec 2020 09:18:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2ADE522225 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OlOejSSCVEK69CCl8MOKHsGwsA1mUCdkZuZKPzF3gK8=; b=rJFUPRHE9PLm0KxzeUTRCu1jS h4YdixOnGeAEZiVSQ83DRbUaH/x06WVKbeYfFhERyBKBTuj2vJAHA430OcQjOLO3tiNlitwuYxit3 sBqq1bsseSs1qsq8pWX24VVUmm4CIeQSRsKpKHTSXlJXSmyG4+RQPCTtywUBy4KWxWpxzONmWr9Dw EJvKUPt1HE5RsHUlupkWR9glx8tFkuJ6OgMTaPsvTPcIJ8movXR7wVLI+k8tSZFBoIRgUpGqEWZLX 2o8/rT6oDOFApTHPgUhbDcIKCmMz3HQ8uHZd7r50XLcXVMPB6oBwGQx1a+//Y2I8Q8bFI3dXuUo25 QujX6VtiQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp6Se-0006rh-Pq; Tue, 15 Dec 2020 09:17:36 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp6Sb-0006qq-Hc for linux-arm-kernel@lists.infradead.org; Tue, 15 Dec 2020 09:17:34 +0000 Received: by mail-ed1-f66.google.com with SMTP id u19so20230107edx.2 for ; Tue, 15 Dec 2020 01:17:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=dZQENcWGBI+dh1Iu6ct/S1F9dcvge+tYCMiVe0Z+KKs=; b=X5Ls7M81IWk3mkvrXJmU3ZlCrV0DrO/H2M5rYTppkuX0JE0kqqd3C60D/xUjjkjjZb m+B2V9faNlBoRvkK3HfGZoitUEbOtgWpc6DEvIYGVwLhnbvWT8qFislfntsbPfa943nh 0Plgpm4Xx+bkyw++Ek9FlX2pq3qZzlrBA4sDL5QrZ9oktk4RGa7IeucCTVUcWGfJEFIC rD5rTmTRlWE9LjX5vqydbr7YAdKKnTtyd8B86XFRk7Q7+3KbOnYUVrV5xh6pp1OWHhXb ao7ZqmaOb4DMLY28bAtLe/ESYZpGwQAN2qpNgG2xo5CgOPxAAZvamwvp8PnLExp2N6RZ 4tmQ== X-Gm-Message-State: AOAM531VapWiQDYFGAp0khyFrkPR4e3Udbr2YQOF4NUpbx/nMRkxBCz9 MmQqtxa5oesVVeyUdpSwkgg= X-Google-Smtp-Source: ABdhPJzyj6ItHNGHotBpHYpNXSrGsP+uSjgbyPB4ibTWWi2Ly5OfFzTeJj8EKPMmRG6BpZiVFYn+1A== X-Received: by 2002:a50:a692:: with SMTP id e18mr28471961edc.233.1608023852372; Tue, 15 Dec 2020 01:17:32 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id ch30sm18207744edb.8.2020.12.15.01.17.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Dec 2020 01:17:31 -0800 (PST) Date: Tue, 15 Dec 2020 10:17:29 +0100 From: Krzysztof Kozlowski To: Guido =?utf-8?Q?G=C3=BCnther?= Subject: Re: [PATCH 1/4] arm64: defconfig: Enable Librem5 Devkit components Message-ID: <20201215091729.GC29321@kozik-lap> References: <53657bbcaf1292fe58fa8dce497af6734521fb10.1607879709.git.agx@sigxcpu.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <53657bbcaf1292fe58fa8dce497af6734521fb10.1607879709.git.agx@sigxcpu.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201215_041733_592058_B9CC6785 X-CRM114-Status: GOOD ( 12.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Will Deacon , Anson Huang , Shawn Guo , Sascha Hauer , Angus Ainslie , Michael Walle , Bjorn Andersson , Vinod Koul , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Catalin Marinas , Martin Kepplinger , Li Yang , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCBEZWMgMTMsIDIwMjAgYXQgMDY6MTc6MTFQTSArMDEwMCwgR3VpZG8gR8O8bnRoZXIg d3JvdGU6Cj4gVGhpcyBlbmFibGVzCj4gCj4gLSB0b3VjaHNjcmVlbjogQ09ORklHX1RPVUNIU0NS RUVOX0dPT0RJWAo+IC0gY2hhcmdlIGNvbnRyb2xsZXI6IENPTkZJR19DSEFSR0VSX0JRMjU4OTAK PiAtIGF1ZGlvIGNvZGVjOiBDT05GSUdfU05EX1NPQ19JTVhfU0dUTDUwMDAKPiAtIHJ0YzogQ09O RklHX1JUQ19EUlZfTTQxVDgwCj4gLSBtYWduZXRvbWV0ZXI6IENPTkZJR19JSU9fU1RfTUFHTl8z QVhJUwo+IC0gcHdtOiBDT05GSUdfUFdNX0lNWDI3Cj4gLSBtb2RlbSBjb2RlYzogQ09ORklHX1NO RF9TT0NfR1RNNjAxCj4gLSBtb2RlbSBzZXJpYWw6IENPTkZJR19VU0JfU0VSSUFMX09QVElPTgoK RG8gbm90IHJlcGVhdCB0aGUgY29udGVudHMgb2YgdGhlIHBhdGNoLiBXZSBjYW4gZWFzaWx5IHNl ZSB3aGljaCBjb25maWdzCnlvdSBlbmFibGUuIEluc3RlYWQsIHBsZWFzZSBuYW1lIHRoZSBkZXZp Y2VzIHlvdSB3YW50IHRvIHVzZSwgbm90IHRoZQpDT05GSUcgZW50cmllcy4gIFNldmVyYWwgZHJp dmVycyBhY3R1YWxseSBzdXBwb3J0IG11bHRpcGxlIGRldmljZXMuCgpEZXNjcmliZSBhbHNvIHRo ZSBib2FyZCB5b3UgYXJlIGVuYWJsaW5nIGl0IGZvci4gWW91IHdyb3RlIG9ubHkKIkxpYnJlbTUi LCBidXQgSSBhbSBub3Qgc3VyZSB3aGV0aGVyIHRoaXMgaXMgc3BlY2lmaWMgZW5vdWdoLiBJcyBp dCBldmVuCm9uIE5YUCBpLk1YIHByb2Nlc3Nvcj8gTWF5YmUgb24gc29tZXRoaW5nIGVsc2U/CgpU aGlzIGlzIGEgZ2VuZXJpYyBkZWZjb25maWcgc28geW91ciBjaGFuZ2Ugd2lsbCBhZmZlY3QgZXZl cnlvbmUuCgpCZXN0IHJlZ2FyZHMsCktyenlzenRvZgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=