All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [PATCH v1] x86: tangier: Find proper memory region for relocation
Date: Tue, 15 Dec 2020 12:05:30 +0200	[thread overview]
Message-ID: <20201215100530.GP4077@smile.fi.intel.com> (raw)
In-Reply-To: <CAPnjgZ1ep8=hNW=WQ9fd0MRNByq+0MPPF0P63Hyp7Jqzttapdw@mail.gmail.com>

On Mon, Nov 30, 2020 at 01:12:17PM -0700, Simon Glass wrote:
> On Fri, 27 Nov 2020 at 05:40, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > It appears that U-Boot works by luck on Intel Edison board because the amount
> > of RAM is less than 1 GB and standard way of calculating the top of it work
> > for this configuration. However, this won't work if the amount of RAM is
> > different and split differently in address space. We have to fine the suitable
> > window correctly.
> >
> > Find proper memory region for relocation by scanning MMAP SFI table in
> > board_get_usable_ram_top() callback.
> >
> > According to the address map documentation the Main Memory is guaranteed to lie
> > in the 0..2 GB range, that's why we limit search by this range.
> >
> > Fixes: e71de54a4943 ("x86: Add Intel Tangier support")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  arch/x86/cpu/tangier/sdram.c | 43 ++++++++++++++++++++++++++++++++++++
> >  1 file changed, 43 insertions(+)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>

Thanks!

Bin, can we get this, somehow important fix, into v2021.01 release?
And any comments about the rest tangier/edison patches?

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2020-12-15 10:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-27 12:40 [PATCH v1] x86: tangier: Find proper memory region for relocation Andy Shevchenko
2020-11-30 20:12 ` Simon Glass
2020-12-15 10:05   ` Andy Shevchenko [this message]
2020-12-15 13:09     ` Bin Meng
2020-12-16  3:32 ` Bin Meng
2020-12-16  5:52   ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201215100530.GP4077@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.