All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH 1/2] set_elem: Use nftnl_data_reg_snprintf()
Date: Tue, 15 Dec 2020 11:13:04 +0100	[thread overview]
Message-ID: <20201215101304.GG28824@orbyte.nwl.cc> (raw)
In-Reply-To: <20201214183023.GA9271@salvia>

Hi Pablo,

On Mon, Dec 14, 2020 at 07:30:23PM +0100, Pablo Neira Ayuso wrote:
> On Mon, Dec 14, 2020 at 07:02:50PM +0100, Phil Sutter wrote:
> > Introduce a flag to allow toggling the '0x' prefix when printing data
> > values, then use the existing routines to print data registers from
> > set_elem code.
> 
> Patches LGTM.

Thanks, I'll push it along with the change in nftables' tests/py.

> You will have to update tests/py too, right?

To my surprise, it's merely a single test case that needed adjustment.
Either I missed something (testing stops before payload comparison if
e.g. input and output differ) or we really have quite low concat-range
coverage.

Cheers, Phil

      reply	other threads:[~2020-12-15 10:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14 18:02 [libnftnl PATCH 1/2] set_elem: Use nftnl_data_reg_snprintf() Phil Sutter
2020-12-14 18:02 ` [libnftnl PATCH 2/2] set_elem: Include key_end data reg in print output Phil Sutter
2020-12-14 18:30 ` [libnftnl PATCH 1/2] set_elem: Use nftnl_data_reg_snprintf() Pablo Neira Ayuso
2020-12-15 10:13   ` Phil Sutter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201215101304.GG28824@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.