From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CEF7C4361B for ; Tue, 15 Dec 2020 11:57:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13C972228A for ; Tue, 15 Dec 2020 11:57:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13C972228A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X9AgJziaNWJoh5YaUPJi1Y2ENfd1KeoAfg/RlsiJbyM=; b=EqimDupw54L0da0QyAzz+zHxI 4Kh7qsS8erOcm5aPizXg+fcaOumrctAhkdZZcwWNqC+jSLNWRaMz+Upg7RQmOXQB1al9r2k3TkbwM YJUyugkw4lQ0TDqp56ZXfWdYd5yLleJrb1sVdAhQQKIjQR8i8GVRKw397oVR3B+NW0Ezbvpyeej+j DzyzK9HkeuEntg3XKNbscZWxXJ2xtN+6eoslzDBH0um+ZbKdm0Ftjla09P10WfteCdzlcD4/Jebg1 aP/AXeOLb+VLrL0uCBMZkN2jxm2Ya94Zd+994Hkac1A8BFKj308onipZ8kAUpsxW2sfHtD/g5CR5g 2B08lYQow==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp8w6-0000f9-Gt; Tue, 15 Dec 2020 11:56:10 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp8w4-0000el-BD for linux-arm-kernel@lists.infradead.org; Tue, 15 Dec 2020 11:56:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A67030E; Tue, 15 Dec 2020 03:56:07 -0800 (PST) Received: from localhost (e108754-lin.cambridge.arm.com [10.1.198.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A72533F66E; Tue, 15 Dec 2020 03:56:06 -0800 (PST) Date: Tue, 15 Dec 2020 11:56:05 +0000 From: Ionela Voinescu To: Viresh Kumar Subject: Re: [PATCH V3 3/3] arm64: topology: Make AMUs work with modular cpufreq drivers Message-ID: <20201215115605.GB25331@arm.com> References: <5ffc7b9ed03c6301ac2f710f609282959491b526.1608010334.git.viresh.kumar@linaro.org> <8f0fe23d1c9effed71d5660c939472d43726a61b.1608010334.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8f0fe23d1c9effed71d5660c939472d43726a61b.1608010334.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201215_065608_459786_8A82ED06 X-CRM114-Status: GOOD ( 19.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vincent Guittot Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tuesday 15 Dec 2020 at 11:04:16 (+0530), Viresh Kumar wrote: > The AMU counters won't get used today if the cpufreq driver is built as > a module as the amu core requires everything to be ready by late init. > > Fix that properly by registering for cpufreq policy notifier. Note that > the amu core don't have any cpufreq dependency after the first time > CPUFREQ_CREATE_POLICY notifier is called for all the CPUs. And so we > don't need to do anything on the CPUFREQ_REMOVE_POLICY notifier. And for > the same reason we check if the CPUs are already parsed in the beginning > of amu_fie_setup() and skip if that is true. Alternatively we can shoot > a work from there to unregister the notifier instead, but that seemed > too much instead of this simple check. > > Signed-off-by: Viresh Kumar > --- > V3: > - This is a new patch. > > Ionela, > > I don't have a way to test the AMU stuff, will it be possible for you to > give it a try ? > I'll review this new patch and then I'll give the full set a try. Thanks for the interest in improving this, Ionela. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B309FC4361B for ; Tue, 15 Dec 2020 11:58:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65AE92228A for ; Tue, 15 Dec 2020 11:58:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728755AbgLOL56 (ORCPT ); Tue, 15 Dec 2020 06:57:58 -0500 Received: from foss.arm.com ([217.140.110.172]:36564 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728614AbgLOL4w (ORCPT ); Tue, 15 Dec 2020 06:56:52 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A67030E; Tue, 15 Dec 2020 03:56:07 -0800 (PST) Received: from localhost (e108754-lin.cambridge.arm.com [10.1.198.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A72533F66E; Tue, 15 Dec 2020 03:56:06 -0800 (PST) Date: Tue, 15 Dec 2020 11:56:05 +0000 From: Ionela Voinescu To: Viresh Kumar Cc: Catalin Marinas , Will Deacon , Vincent Guittot , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 3/3] arm64: topology: Make AMUs work with modular cpufreq drivers Message-ID: <20201215115605.GB25331@arm.com> References: <5ffc7b9ed03c6301ac2f710f609282959491b526.1608010334.git.viresh.kumar@linaro.org> <8f0fe23d1c9effed71d5660c939472d43726a61b.1608010334.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8f0fe23d1c9effed71d5660c939472d43726a61b.1608010334.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday 15 Dec 2020 at 11:04:16 (+0530), Viresh Kumar wrote: > The AMU counters won't get used today if the cpufreq driver is built as > a module as the amu core requires everything to be ready by late init. > > Fix that properly by registering for cpufreq policy notifier. Note that > the amu core don't have any cpufreq dependency after the first time > CPUFREQ_CREATE_POLICY notifier is called for all the CPUs. And so we > don't need to do anything on the CPUFREQ_REMOVE_POLICY notifier. And for > the same reason we check if the CPUs are already parsed in the beginning > of amu_fie_setup() and skip if that is true. Alternatively we can shoot > a work from there to unregister the notifier instead, but that seemed > too much instead of this simple check. > > Signed-off-by: Viresh Kumar > --- > V3: > - This is a new patch. > > Ionela, > > I don't have a way to test the AMU stuff, will it be possible for you to > give it a try ? > I'll review this new patch and then I'll give the full set a try. Thanks for the interest in improving this, Ionela.