From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B0AEC4361B for ; Tue, 15 Dec 2020 12:32:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 221FC224D2 for ; Tue, 15 Dec 2020 12:32:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 221FC224D2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0YiP08iHQ07QPqMxzFVIn6KnQESLkXipBMiSyLegUIU=; b=Xdlt+sxH3omfdnIZGlWT2aASm EhcsoKiWHIRL4f4Hu6bA5srZ+LTfH4a2L5wLVPLLgR5EfdKEEmwBug1pNZbLQjLq+yPk6STVKErnf CjOg8U7L1cC7ArKE4Ql+JEzeh9rOGQEE6dFqiD2X4exJSWWg1g5Wb383T0C1MjU7npsaZtZn6YqRT WTZlRAbImUrIUadThnZ8Kddl3rSKGJGa67BWcoe8YXyl+fafAK8Kzb74TgwFKSSPeQgHLeuTRdPBd bos5aN9nb0DgBFtzoDlL7RLyn6INvq4W9fInPv0/J/K4UM+kyWFjCAs6XQigvKpiFZ6/pIKeTicrr ImQxMltTA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp9TH-0004bz-M6; Tue, 15 Dec 2020 12:30:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp9TF-0004am-1b for linux-arm-kernel@lists.infradead.org; Tue, 15 Dec 2020 12:30:25 +0000 Date: Tue, 15 Dec 2020 12:30:20 +0000 From: Catalin Marinas To: Viresh Kumar Subject: Re: [PATCH] arm64: topology: Drop the useless update to per-cpu cycles Message-ID: <20201215123019.GB2511@gaia> References: <7a171f710cdc0f808a2bfbd7db839c0d265527e7.1607579234.git.viresh.kumar@linaro.org> <20201211064850.gsqsszwhxx5lzqgw@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201211064850.gsqsszwhxx5lzqgw@vireshk-i7> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201215_073025_173836_4DC02625 X-CRM114-Status: GOOD ( 17.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vincent Guittot , Will Deacon , linux-kernel@vger.kernel.org, Sudeep Holla , Ionela Voinescu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 11, 2020 at 12:18:50PM +0530, Viresh Kumar wrote: > On 10-12-20, 11:17, Viresh Kumar wrote: > > The previous call to update_freq_counters_refs() has already updated the > > per-cpu variables, don't overwrite them with the same value again. > > > > Fixes: 4b9cf23c179a ("arm64: wrap and generalise counter read functions") > > Signed-off-by: Viresh Kumar > > --- > > arch/arm64/kernel/topology.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c > > index c8308befdb1e..f6faa697e83e 100644 > > --- a/arch/arm64/kernel/topology.c > > +++ b/arch/arm64/kernel/topology.c > > @@ -314,7 +314,7 @@ void topology_scale_freq_tick(void) > > > > if (unlikely(core_cnt <= prev_core_cnt || > > const_cnt <= prev_const_cnt)) > > - goto store_and_exit; > > + return; > > > > /* > > * /\core arch_max_freq_scale > > @@ -331,10 +331,6 @@ void topology_scale_freq_tick(void) > > > > scale = min_t(unsigned long, scale, SCHED_CAPACITY_SCALE); > > this_cpu_write(freq_scale, (unsigned long)scale); > > - > > -store_and_exit: > > - this_cpu_write(arch_core_cycles_prev, core_cnt); > > - this_cpu_write(arch_const_cycles_prev, const_cnt); > > } > > > > #ifdef CONFIG_ACPI_CPPC_LIB > > Catalin: Can you please pick this up for 5.11-rc1, the earlier patch > (from fixes) is already in your tree. Thanks. I will add it to the second pull request this merging window. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EACBEC4361B for ; Tue, 15 Dec 2020 12:31:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B32FA224D4 for ; Tue, 15 Dec 2020 12:31:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729364AbgLOMbX (ORCPT ); Tue, 15 Dec 2020 07:31:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:42682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725855AbgLOMbG (ORCPT ); Tue, 15 Dec 2020 07:31:06 -0500 Date: Tue, 15 Dec 2020 12:30:20 +0000 From: Catalin Marinas To: Viresh Kumar Cc: Will Deacon , Sudeep Holla , Ionela Voinescu , Vincent Guittot , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: topology: Drop the useless update to per-cpu cycles Message-ID: <20201215123019.GB2511@gaia> References: <7a171f710cdc0f808a2bfbd7db839c0d265527e7.1607579234.git.viresh.kumar@linaro.org> <20201211064850.gsqsszwhxx5lzqgw@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201211064850.gsqsszwhxx5lzqgw@vireshk-i7> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 11, 2020 at 12:18:50PM +0530, Viresh Kumar wrote: > On 10-12-20, 11:17, Viresh Kumar wrote: > > The previous call to update_freq_counters_refs() has already updated the > > per-cpu variables, don't overwrite them with the same value again. > > > > Fixes: 4b9cf23c179a ("arm64: wrap and generalise counter read functions") > > Signed-off-by: Viresh Kumar > > --- > > arch/arm64/kernel/topology.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c > > index c8308befdb1e..f6faa697e83e 100644 > > --- a/arch/arm64/kernel/topology.c > > +++ b/arch/arm64/kernel/topology.c > > @@ -314,7 +314,7 @@ void topology_scale_freq_tick(void) > > > > if (unlikely(core_cnt <= prev_core_cnt || > > const_cnt <= prev_const_cnt)) > > - goto store_and_exit; > > + return; > > > > /* > > * /\core arch_max_freq_scale > > @@ -331,10 +331,6 @@ void topology_scale_freq_tick(void) > > > > scale = min_t(unsigned long, scale, SCHED_CAPACITY_SCALE); > > this_cpu_write(freq_scale, (unsigned long)scale); > > - > > -store_and_exit: > > - this_cpu_write(arch_core_cycles_prev, core_cnt); > > - this_cpu_write(arch_const_cycles_prev, const_cnt); > > } > > > > #ifdef CONFIG_ACPI_CPPC_LIB > > Catalin: Can you please pick this up for 5.11-rc1, the earlier patch > (from fixes) is already in your tree. Thanks. I will add it to the second pull request this merging window. Thanks. -- Catalin