From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E82E3C4361B for ; Tue, 15 Dec 2020 16:33:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8E9822571 for ; Tue, 15 Dec 2020 16:33:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730419AbgLOQc5 (ORCPT ); Tue, 15 Dec 2020 11:32:57 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:35806 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729561AbgLOQcz (ORCPT ); Tue, 15 Dec 2020 11:32:55 -0500 Received: by mail-ot1-f67.google.com with SMTP id i6so19966096otr.2; Tue, 15 Dec 2020 08:32:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7YAQAVt9xHPWfTAqPkRDtbeSmHmka4bZA5QuCv8X5zw=; b=OLBLtfJRU17lty7kCH5DghkjJJpsP//I7IQ9w2oYUGwnSOkLiCokCgD/4Tz766TSD8 Mwe/VPrTij2WCzaOrpa78fLFuOjp+M3xjfq/zyZUVyxqA8jGQPHAtZyZzsZ7aWjRbdCf uSPV84sKN9leBULmMkuebppS+oS6aVuVD7XREG8nD/3MaDWEF/2norWxZ9QuE8ss8S4L MfsYpwFhj4tdDpX308/TC8hoXrXxSYa4CdX5t0phWEY+g3C2drNASRUoglYjxhb/LgHn uEAitFl9WtBi139mW/boam6GY6xHZ+fFZmPmmZDSrAlVeCb/Iz7dMAXR+2IIh3W6TkDq 9cAQ== X-Gm-Message-State: AOAM5312n1lkyaeDE8HMZ2QKvnDzfT3eGNjcKHNSn3KPwzDvbqQDJX42 BY2VdmQjdH9r0iw9E+820A== X-Google-Smtp-Source: ABdhPJxuHLb1e0yz4x9X/eFcHxas2aAdH3/P0n37LQH1eEbsb1g0eOoptatCyZ7DZlJdcmpZxBvBfQ== X-Received: by 2002:a9d:6255:: with SMTP id i21mr24143646otk.346.1608049934531; Tue, 15 Dec 2020 08:32:14 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id r14sm523413ote.28.2020.12.15.08.32.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Dec 2020 08:32:13 -0800 (PST) Received: (nullmailer pid 3980195 invoked by uid 1000); Tue, 15 Dec 2020 16:32:12 -0000 Date: Tue, 15 Dec 2020 10:32:12 -0600 From: Rob Herring To: Icenowy Zheng Cc: Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Brown , linux-spi@vger.kernel.org Subject: Re: [RFC PATCH 10/12] dt-bindings: spi: sun6i: add compatible for V831 SPI Message-ID: <20201215163212.GA3972588@robh.at.kernel.org> References: <20201212040157.3639864-1-icenowy@aosc.io> <20201212051202.3645115-1-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201212051202.3645115-1-icenowy@aosc.io> Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Sat, Dec 12, 2020 at 01:12:00PM +0800, Icenowy Zheng wrote: > V831 has a SPI controller similar to the H6 one. > > Add a compatible string for it. > > Cc: Mark Brown > Cc: linux-spi@vger.kernel.org > Signed-off-by: Icenowy Zheng > --- > H6 and V831 SPI controllers is not totally the same with H3: they have > QSPI support added. Here V831 compatible string is just added in > parallel with H6 one, but maybe we should make H6 SPI do not fallback to > H3 one, and add H6 one as fallback to V831? A fallback is really only needed if there's a user you expect to work unmodified. For example, say a new DMA mode is added, but that's something a bootloader wouldn't use. Given QSPI mode is probably fundamentally different?, then a fallback is probably not needed. > > .../devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml > index 7866a655d81c..a620ff30033e 100644 > --- a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml > +++ b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml > @@ -24,6 +24,7 @@ properties: > - items: > - enum: > - allwinner,sun8i-r40-spi > + - allwinner,sun8i-v831-spi > - allwinner,sun50i-h6-spi > - const: allwinner,sun8i-h3-spi > > -- > 2.28.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D09C4361B for ; Tue, 15 Dec 2020 16:33:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 157C522525 for ; Tue, 15 Dec 2020 16:33:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 157C522525 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HeLzCTQ/kkldacqjRo2AISf7w2VFCBDex/KsVRz6w+s=; b=SPiu9T89WcfBbod4iYCUMbSwZ wZGAHuwgiY8ou6kwFtB7qr4bPA0ZvSCAaH6p8xF51Nz27HD23e2eJf1gboDJb8ipAAoKPW5Nnu6ey gEQhwkB5zwtJMDCW5ehFKeX5Bz4Y1ZeSHVdjP50+T16UT81iC1KCKQHQ6IZY2FOC1Fs1FJQ2aiftW eIjjrustje069Sv2X5EcoptSZL9HLNxXQhmGUPN2SuL5RvkSINArUlDOYLG1OT0s2pEQXKf4Oy5vo BOwz5EVipXGp42+BFLZ9g74POKJeRcp4BpL7UwJ1t90wHLWSmDp0+U8rG0IzNe+mddU0I+/gyI4x/ yxUmb/UTA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpDFK-0003HZ-K0; Tue, 15 Dec 2020 16:32:18 +0000 Received: from mail-ot1-f65.google.com ([209.85.210.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpDFH-0003Gz-HW for linux-arm-kernel@lists.infradead.org; Tue, 15 Dec 2020 16:32:16 +0000 Received: by mail-ot1-f65.google.com with SMTP id h18so19948044otq.12 for ; Tue, 15 Dec 2020 08:32:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7YAQAVt9xHPWfTAqPkRDtbeSmHmka4bZA5QuCv8X5zw=; b=PWgMVYlkVB24KMotUC5ugINSqeN1Y+xcuSthXqNcD4fGt4kBY1u8bsDqg5Vw77EeGm 2kMX6ZmLAS2lfunpkCxx5ZuJgKaKNT+kzHvBZJhLvdhYhMtS+o85DU/avZGq5KH1sqnx 9fUqAtwt6A56IFv+2FkaZnFqBkhx/vNL8y0K4yaWuXDEZ+igtBcOFrgJIvOKH6df7t9u yd9M+zuezgAQfN1C7PeXOgD9l9wRsExFJN7PxskQfpkyNgwl+/B0o2dcyCZFhdCbPuYn uTfZybUbp4U0bjgm90SZ8KAhnS8DbW3y/Ez7yd+09tlPUiPc933TfYwHiHf4K/Llj7o5 PIwQ== X-Gm-Message-State: AOAM532ZO3hJD6fzESpv334Yj3+eIuRrHtqU7Ief0PlsmvQhB3FPYqT0 kg2f3zWVB8eoMLhMgVZzr+wmG3kTiQ== X-Google-Smtp-Source: ABdhPJxuHLb1e0yz4x9X/eFcHxas2aAdH3/P0n37LQH1eEbsb1g0eOoptatCyZ7DZlJdcmpZxBvBfQ== X-Received: by 2002:a9d:6255:: with SMTP id i21mr24143646otk.346.1608049934531; Tue, 15 Dec 2020 08:32:14 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id r14sm523413ote.28.2020.12.15.08.32.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Dec 2020 08:32:13 -0800 (PST) Received: (nullmailer pid 3980195 invoked by uid 1000); Tue, 15 Dec 2020 16:32:12 -0000 Date: Tue, 15 Dec 2020 10:32:12 -0600 From: Rob Herring To: Icenowy Zheng Subject: Re: [RFC PATCH 10/12] dt-bindings: spi: sun6i: add compatible for V831 SPI Message-ID: <20201215163212.GA3972588@robh.at.kernel.org> References: <20201212040157.3639864-1-icenowy@aosc.io> <20201212051202.3645115-1-icenowy@aosc.io> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201212051202.3645115-1-icenowy@aosc.io> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201215_113215_665514_371003BA X-CRM114-Status: GOOD ( 20.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jernej Skrabec , linux-kernel@vger.kernel.org, Maxime Ripard , linux-spi@vger.kernel.org, Chen-Yu Tsai , Mark Brown , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Dec 12, 2020 at 01:12:00PM +0800, Icenowy Zheng wrote: > V831 has a SPI controller similar to the H6 one. > > Add a compatible string for it. > > Cc: Mark Brown > Cc: linux-spi@vger.kernel.org > Signed-off-by: Icenowy Zheng > --- > H6 and V831 SPI controllers is not totally the same with H3: they have > QSPI support added. Here V831 compatible string is just added in > parallel with H6 one, but maybe we should make H6 SPI do not fallback to > H3 one, and add H6 one as fallback to V831? A fallback is really only needed if there's a user you expect to work unmodified. For example, say a new DMA mode is added, but that's something a bootloader wouldn't use. Given QSPI mode is probably fundamentally different?, then a fallback is probably not needed. > > .../devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml > index 7866a655d81c..a620ff30033e 100644 > --- a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml > +++ b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml > @@ -24,6 +24,7 @@ properties: > - items: > - enum: > - allwinner,sun8i-r40-spi > + - allwinner,sun8i-v831-spi > - allwinner,sun50i-h6-spi > - const: allwinner,sun8i-h3-spi > > -- > 2.28.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel