All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Ross Lagerwall <ross.lagerwall@citrix.com>
Subject: Re: [PATCH v2 4/4] livepatch: adjust a stale comment
Date: Tue, 15 Dec 2020 11:34:52 -0500	[thread overview]
Message-ID: <20201215163452.GA349@char.us.oracle.com> (raw)
In-Reply-To: <659b188d-d26e-3351-2285-3e75197e2c5f@suse.com>

On Tue, Dec 15, 2020 at 05:13:43PM +0100, Jan Beulich wrote:
> As of 005de45c887e ("xen: do live patching only from main idle loop")
> the comment ahead of livepatch_do_action() has been stale.
> 
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Thank you!
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/common/livepatch.c
> +++ b/xen/common/livepatch.c
> @@ -1392,8 +1392,8 @@ static inline bool was_action_consistent
>  }
>  
>  /*
> - * This function is executed having all other CPUs with no deep stack (we may
> - * have cpu_idle on it) and IRQs disabled.
> + * This function is executed having all other CPUs with no deep stack (when
> + * idle) and IRQs disabled.
>   */
>  static void livepatch_do_action(void)
>  {
> 


      reply	other threads:[~2020-12-15 16:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15 16:09 [PATCH v2 0/4] x86: XSA-348 follow-up Jan Beulich
2020-12-15 16:11 ` [PATCH v2 1/4] x86: verify function type (and maybe attribute) in switch_stack_and_jump() Jan Beulich
2020-12-15 16:28   ` Wei Liu
2020-12-21 16:23   ` Julien Grall
2020-12-15 16:12 ` [PATCH v2 2/4] x86: clobber registers in switch_stack_and_jump() when !LIVEPATCH Jan Beulich
2020-12-15 16:28   ` Wei Liu
2020-12-15 16:12 ` [PATCH v2 3/4] x86/PV: avoid double stack reset during schedule tail handling Jan Beulich
2020-12-15 16:29   ` Wei Liu
2020-12-15 16:13 ` [PATCH v2 4/4] livepatch: adjust a stale comment Jan Beulich
2020-12-15 16:34   ` Konrad Rzeszutek Wilk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201215163452.GA349@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=jbeulich@suse.com \
    --cc=ross.lagerwall@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.