From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: linux-edac <linux-edac@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] EDAC/amd64: Merge error injection sysfs facilities
Date: Tue, 15 Dec 2020 19:58:08 +0100 [thread overview]
Message-ID: <20201215185808.GE9817@zn.tnic> (raw)
In-Reply-To: <20201215161120.GB2122783@yaz-nikka.amd.com>
On Tue, Dec 15, 2020 at 10:11:20AM -0600, Yazen Ghannam wrote:
> Can we say "Opterons (Family 10h to Family 15h)"? It may also apply to
> Family 16h, but I don't know if they were branded as Opterons.
>
> The injection code in this module doesn't apply to Family 17h and later.
>
> Also, Family 17h and later doesn't allow the OS direct access to the error
> injection registers. They're locked down by security policy, etc.
Yeah, figured as much after I started getting all 0s while poking at
them with setpci...
Ok, I'll fix that ontop - this patch should be only code movement and
trivial cleanups, functionality changes ontop.
> Related to the comment above, can this be changed to the following?
>
> if (pvt->fam < 0x10 || pvt->fam >= 0x17)
Right.
> Everything else looks good to me.
>
> Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-12-15 19:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 11:05 [PATCH 1/2] EDAC/amd64: Merge sysfs debugging attributes setup code Borislav Petkov
2020-12-15 11:05 ` [PATCH 2/2] EDAC/amd64: Merge error injection sysfs facilities Borislav Petkov
2020-12-15 16:11 ` Yazen Ghannam
2020-12-15 18:58 ` Borislav Petkov [this message]
2020-12-22 18:00 ` Borislav Petkov
2020-12-15 16:01 ` [PATCH 1/2] EDAC/amd64: Merge sysfs debugging attributes setup code Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215185808.GE9817@zn.tnic \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.