From: Lee Jones <lee.jones@linaro.org>
To: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"marek.vasut+renesas@gmail.com" <marek.vasut+renesas@gmail.com>,
"yoshihiro.shimoda.uh@renesas.com"
<yoshihiro.shimoda.uh@renesas.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
linux-power <linux-power@fi.rohmeurope.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"khiem.nguyen.xt@renesas.com" <khiem.nguyen.xt@renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 11/12] mfd: bd9571mwv: Make the driver more generic
Date: Wed, 16 Dec 2020 09:00:45 +0000 [thread overview]
Message-ID: <20201216090045.GA207743@dell> (raw)
In-Reply-To: <4021c3f04bf8c4dcbcb015056455c4acf9e71b6b.camel@fi.rohmeurope.com>
On Wed, 16 Dec 2020, Vaittinen, Matti wrote:
>
> On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote:
> > From: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
> >
> > Since the driver supports BD9571MWV PMIC only,
> > this patch makes the functions and data structure become more generic
> > so that it can support other PMIC variants as well.
> >
> > Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
> > [shimoda: rebase and refactor]
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> Reviewed-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Please place any *-by tags *after* the other comments.
Fortunately, the first one below was still on my screen, else I would
have stopped reading here.
> > ---
> > drivers/mfd/bd9571mwv.c | 95 +++++++++++++++++++++++++++----
> > ------------
> > include/linux/mfd/bd9571mwv.h | 18 ++------
> > 2 files changed, 63 insertions(+), 50 deletions(-)
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-12-16 9:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 7:37 [PATCH v3 00/12] treewide: bd9571mwv: Add support for BD9574MWF Yoshihiro Shimoda
2020-12-16 7:37 ` [PATCH v3 01/12] mfd: bd9571mwv: Use devm_mfd_add_devices() Yoshihiro Shimoda
2020-12-16 15:08 ` Lee Jones
2020-12-16 7:37 ` [PATCH v3 02/12] dt-bindings: mfd: bd9571mwv: Document BD9574MWF Yoshihiro Shimoda
2020-12-16 7:37 ` [PATCH v3 03/12] mfd: rohm-generic: Add BD9571 and BD9574 Yoshihiro Shimoda
2020-12-16 15:09 ` Lee Jones
2020-12-16 7:37 ` [PATCH v3 04/12] regulator: bd9571mwv: rid of using struct bd9571mwv Yoshihiro Shimoda
2020-12-16 7:37 ` [PATCH v3 05/12] regulator: bd9571mwv: Add BD9574MWF support Yoshihiro Shimoda
2020-12-16 7:37 ` [PATCH v3 06/12] gpio: bd9571mwv: Use the SPDX license identifier Yoshihiro Shimoda
2020-12-16 7:37 ` [PATCH v3 07/12] gpio: bd9571mwv: rid of using struct bd9571mwv Yoshihiro Shimoda
2020-12-16 7:37 ` [PATCH v3 08/12] gpio: bd9571mwv: Add BD9574MWF support Yoshihiro Shimoda
2020-12-16 7:37 ` [PATCH v3 09/12] mfd: bd9571mwv: Use the SPDX license identifier Yoshihiro Shimoda
2020-12-16 15:10 ` Lee Jones
2020-12-16 7:37 ` [PATCH v3 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip() Yoshihiro Shimoda
2020-12-16 8:13 ` Vaittinen, Matti
2020-12-16 15:12 ` Lee Jones
2020-12-16 7:37 ` [PATCH v3 11/12] mfd: bd9571mwv: Make the driver more generic Yoshihiro Shimoda
2020-12-16 8:25 ` Vaittinen, Matti
2020-12-16 8:45 ` Vaittinen, Matti
2020-12-16 9:00 ` Lee Jones [this message]
2020-12-16 9:09 ` Vaittinen, Matti
2020-12-16 15:35 ` Lee Jones
2020-12-17 11:44 ` Yoshihiro Shimoda
2020-12-16 7:37 ` [PATCH v3 12/12] mfd: bd9571mwv: Add support for BD9574MWF Yoshihiro Shimoda
2020-12-16 8:45 ` Vaittinen, Matti
2020-12-16 9:02 ` Lee Jones
2020-12-16 9:29 ` Vaittinen, Matti
2020-12-16 15:37 ` Lee Jones
2020-12-17 11:44 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216090045.GA207743@dell \
--to=lee.jones@linaro.org \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=khiem.nguyen.xt@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.