Re: [linux-next:master 6404/13375] drivers/i3c/master/mipi-i3c-hci/core.c:780:34: warning: unused variable 'i3c_hci_of_match'

[Boris Brezillon <boris.brezillon@collabora.com>]

[-- Attachment #1: Type: text/plain, Size: 2992 bytes --]

On Tue, 15 Dec 2020 22:28:42 -0500 (EST)
Nicolas Pitre <nico@fluxnic.net> wrote:

> On Wed, 16 Dec 2020, Souptick Joarder wrote:
> 
> > On Tue, Dec 15, 2020 at 1:31 AM kernel test robot <lkp@intel.com> wrote:  
> > >
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > head:   7bba37a1591369e2e506d599b8f5d7d0516b2dbc
> > > commit: 9ad9a52cce2828d932ae9495181e3d6414f72c07 [6404/13375] i3c/master: introduce the mipi-i3c-hci driver
> > > config: x86_64-randconfig-a013-20201215 (attached as .config)
> > > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project d38205144febf4dc42c9270c6aa3d978f1ef65e1)
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # install x86_64 cross compiling tool for clang build
> > >         # apt-get install binutils-x86-64-linux-gnu
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=9ad9a52cce2828d932ae9495181e3d6414f72c07
> > >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > >         git fetch --no-tags linux-next master
> > >         git checkout 9ad9a52cce2828d932ae9495181e3d6414f72c07
> > >         # save the attached .config to linux build tree
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@intel.com>
> > >
> > > All warnings (new ones prefixed by >>):
> > >  
> > > >> drivers/i3c/master/mipi-i3c-hci/core.c:780:34: warning: unused variable 'i3c_hci_of_match' [-Wunused-const-variable]  
> > >    static const struct of_device_id i3c_hci_of_match[] = {
> > >                                     ^
> > >    1 warning generated.  
> > 
> > CONFIG_OF not enabled.
> > 
> > Does it make sense to remove of_match_ptr() ?
> > 
> > static struct platform_driver i3c_hci_driver = {
> > .probe = i3c_hci_probe,
> > .remove = i3c_hci_remove,
> > .driver = {
> > .name = "mipi-i3c-hci",
> > .of_match_table = of_match_ptr(i3c_hci_of_match),
> > },  
> 
> That... or having #ifdef CONFIG_OF around struct of_device_id.

Or adding a __maybe_unused qualifier. Can you send patch for this so I
can apply it before sending my PR to Linus?

> 
> > > vim +/i3c_hci_of_match +780 drivers/i3c/master/mipi-i3c-hci/core.c
> > >
> > >    779  
> > >  > 780  static const struct of_device_id i3c_hci_of_match[] = {  
> > >    781          { .compatible = "mipi-i3c-hci", },
> > >    782          {},
> > >    783  };
> > >    784  MODULE_DEVICE_TABLE(of, i3c_hci_of_match);
> > >    785
> > >
> > > ---
> > > 0-DAY CI Kernel Test Service, Intel Corporation
> > > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org  
> >