diff for duplicates of <20201216113228.GK2809@kadam> diff --git a/a/1.txt b/N1/1.txt index f23ca8d..74abf01 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -11,7 +11,8 @@ On Wed, Dec 16, 2020 at 10:51:23AM +0000, Roy Im wrote: > An "if" testing for error condition has accidentally been dropped from the code. > error = device_property_read_string(dev, gpi_str3, &str); > + if (!error) -> haptics->gpi_ctl[i].polarity > da7280_haptic_of_gpi_pol_str(dev, str); +> haptics->gpi_ctl[i].polarity = +> da7280_haptic_of_gpi_pol_str(dev, str); > Huh... Well, at least the kbuild bot discovered this using the Smatch diff --git a/a/content_digest b/N1/content_digest index 555a156..a253217 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\0AM6PR10MB1926E4EA344C24F76881E89B85C50@AM6PR10MB1926.EURPRD10.PROD.OUTLOOK.COM\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH] Input: da7280 - delete a stray tab\0" - "Date\0Wed, 16 Dec 2020 11:32:28 +0000\0" + "Date\0Wed, 16 Dec 2020 14:32:28 +0300\0" "To\0Roy Im <roy.im.opensource@diasemi.com>\0" "Cc\0Support Opensource <Support.Opensource@diasemi.com>" Dmitry Torokhov <dmitry.torokhov@gmail.com> @@ -23,7 +23,8 @@ "> An \"if\" testing for error condition has accidentally been dropped from the code.\n" "> \t\terror = device_property_read_string(dev, gpi_str3, &str);\n" "> +\t\tif (!error)\n" - "> \t\t\thaptics->gpi_ctl[i].polarity > \t\t\t\tda7280_haptic_of_gpi_pol_str(dev, str);\n" + "> \t\t\thaptics->gpi_ctl[i].polarity =\n" + "> \t\t\t\tda7280_haptic_of_gpi_pol_str(dev, str);\n" "> \n" "\n" "Huh... Well, at least the kbuild bot discovered this using the Smatch\n" @@ -41,4 +42,4 @@ "regards,\n" dan carpenter -44b5919be8dff6b90425eb6184561f73d8ea1d87ab6bed43c26c7905aa22e198 +181987ef7d37f6e08b308f6972ecc95a7d409ac409c928c007ab36d0bcac21fc
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.