From: Guenter Roeck <linux@roeck-us.net>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (w83627ehf) Switch to using the new API kobj_to_dev()
Date: Wed, 16 Dec 2020 08:36:47 -0800 [thread overview]
Message-ID: <20201216163647.GA59939@roeck-us.net> (raw)
In-Reply-To: <1607907735-17510-1-git-send-email-tiantao6@hisilicon.com>
On Mon, Dec 14, 2020 at 09:02:15AM +0800, Tian Tao wrote:
> Switch to using the new API kobj_to_dev() to fix the below warnning:
> drivers/hwmon/w83627ehf.c:1113:60-61: WARNING opportunity for
> kobj_to_dev().
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/w83627ehf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
> index 3964cea..8618aaf 100644
> --- a/drivers/hwmon/w83627ehf.c
> +++ b/drivers/hwmon/w83627ehf.c
> @@ -1110,7 +1110,7 @@ clear_caseopen(struct device *dev, struct w83627ehf_data *data, int channel,
> static umode_t w83627ehf_attrs_visible(struct kobject *kobj,
> struct attribute *a, int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct w83627ehf_data *data = dev_get_drvdata(dev);
> struct device_attribute *devattr;
> struct sensor_device_attribute *sda;
prev parent reply other threads:[~2020-12-16 16:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 1:02 [PATCH] hwmon: (w83627ehf) Switch to using the new API kobj_to_dev() Tian Tao
2020-12-16 16:36 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216163647.GA59939@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.