From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8381C4361B for ; Wed, 16 Dec 2020 19:50:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86B1123137 for ; Wed, 16 Dec 2020 19:50:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728662AbgLPTuv (ORCPT ); Wed, 16 Dec 2020 14:50:51 -0500 Received: from foss.arm.com ([217.140.110.172]:43854 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728657AbgLPTuv (ORCPT ); Wed, 16 Dec 2020 14:50:51 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 05EEB31B; Wed, 16 Dec 2020 11:50:05 -0800 (PST) Received: from localhost (unknown [10.1.198.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 921BB3F66E; Wed, 16 Dec 2020 11:50:04 -0800 (PST) Date: Wed, 16 Dec 2020 19:50:03 +0000 From: Ionela Voinescu To: Viresh Kumar Cc: Rafael Wysocki , linux-pm@vger.kernel.org, Vincent Guittot , Peter Puhov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC V2 0/2] cpufreq: cppc: Add support for frequency invariance Message-ID: <20201216195003.GA21585@arm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi, On Tuesday 15 Dec 2020 at 16:46:34 (+0530), Viresh Kumar wrote: > Hello, > > CPPC cpufreq driver is used for ARM servers and this patch series tries > to provide frequency invariance support for them. > Nitpick: cppc_cpufreq already supports cpufreq-based frequency invariance, but not counter-based frequency invariance, when lacking AMUs :). > This is tested with some hacks, as I didn't have access to the right > hardware, on the ARM64 hikey board to check the overall functionality > and that works fine. > > Ionela/Peter Puhov, it would be nice if you guys can give this a shot. > I'll be on holiday starting tomorrow until January. I fully intend to review and test this but I'll have to set myself a deadline for January to do it. Sorry for the delay, Ionela. > This is based of pm/linux-next and patches [1] and [2] which I sent > recently to cleanup arm64 topology stuff. > > Changes since V1: > - The interface for setting the callbacks is improved, so different > parts looking to provide their callbacks don't need to think about > each other. > > - Moved to per-cpu storage for storing the callback related data, AMU > counters have higher priority with this. > > -- > viresh > > [1] https://lore.kernel.org/lkml/7a171f710cdc0f808a2bfbd7db839c0d265527e7.1607579234.git.viresh.kumar@linaro.org/ > [2] https://lore.kernel.org/lkml/5ffc7b9ed03c6301ac2f710f609282959491b526.1608010334.git.viresh.kumar@linaro.org/ > > Viresh Kumar (2): > topology: Allow multiple entities to provide sched_freq_tick() > callback > cpufreq: cppc: Add support for frequency invariance > > arch/arm64/include/asm/topology.h | 8 +- > arch/arm64/kernel/topology.c | 89 +++++++++---------- > drivers/base/arch_topology.c | 56 +++++++++++- > drivers/cpufreq/cppc_cpufreq.c | 140 +++++++++++++++++++++++++++++- > include/linux/arch_topology.h | 14 ++- > kernel/sched/core.c | 1 + > 6 files changed, 244 insertions(+), 64 deletions(-) > > -- > 2.25.0.rc1.19.g042ed3e048af > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CEA9C4361B for ; Wed, 16 Dec 2020 19:51:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 239C323102 for ; Wed, 16 Dec 2020 19:51:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 239C323102 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iNoFmPxbrKD+TiG9BR2N/HVUWbhRfYB8qMyxKPlaTRg=; b=nW0v9sN3dUs58U9sqsMxNfnUA TvzxIoC/LMdJLVBHWfmrH1mxuQ514nTvKwMmOlPLO86cSrlW54tiWV6C10JA0kCRo50T95Ecj69lk /cXbj4wMC/56AdxsbUOExdPx+kd2+fW2B5iI1QkOsyYVs22zqNWj/nZ2Zsqzj49T5SBOcTTBo14Jg mDIyghYy6vyid07r0vgr+HraeZRyGRPeRtanUlSYkwoqcuyh2IeRg7S9zg/PaIBndwkKcaYBW/30h q+RkTbZ5+E096Z21hd52TU+2BeuGZPKh9HHl0ei9E+T/J7iAv4JZUORPLUBRljMBlGdTBiuhExEKH eJ2LSa9eg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpcoN-0003Sv-B1; Wed, 16 Dec 2020 19:50:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpcoK-0003SM-0e for linux-arm-kernel@lists.infradead.org; Wed, 16 Dec 2020 19:50:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 05EEB31B; Wed, 16 Dec 2020 11:50:05 -0800 (PST) Received: from localhost (unknown [10.1.198.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 921BB3F66E; Wed, 16 Dec 2020 11:50:04 -0800 (PST) Date: Wed, 16 Dec 2020 19:50:03 +0000 From: Ionela Voinescu To: Viresh Kumar Subject: Re: [RFC V2 0/2] cpufreq: cppc: Add support for frequency invariance Message-ID: <20201216195003.GA21585@arm.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201216_145008_345226_EF671A0A X-CRM114-Status: GOOD ( 21.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vincent Guittot , linux-pm@vger.kernel.org, Rafael Wysocki , linux-kernel@vger.kernel.org, Peter Puhov , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tuesday 15 Dec 2020 at 16:46:34 (+0530), Viresh Kumar wrote: > Hello, > > CPPC cpufreq driver is used for ARM servers and this patch series tries > to provide frequency invariance support for them. > Nitpick: cppc_cpufreq already supports cpufreq-based frequency invariance, but not counter-based frequency invariance, when lacking AMUs :). > This is tested with some hacks, as I didn't have access to the right > hardware, on the ARM64 hikey board to check the overall functionality > and that works fine. > > Ionela/Peter Puhov, it would be nice if you guys can give this a shot. > I'll be on holiday starting tomorrow until January. I fully intend to review and test this but I'll have to set myself a deadline for January to do it. Sorry for the delay, Ionela. > This is based of pm/linux-next and patches [1] and [2] which I sent > recently to cleanup arm64 topology stuff. > > Changes since V1: > - The interface for setting the callbacks is improved, so different > parts looking to provide their callbacks don't need to think about > each other. > > - Moved to per-cpu storage for storing the callback related data, AMU > counters have higher priority with this. > > -- > viresh > > [1] https://lore.kernel.org/lkml/7a171f710cdc0f808a2bfbd7db839c0d265527e7.1607579234.git.viresh.kumar@linaro.org/ > [2] https://lore.kernel.org/lkml/5ffc7b9ed03c6301ac2f710f609282959491b526.1608010334.git.viresh.kumar@linaro.org/ > > Viresh Kumar (2): > topology: Allow multiple entities to provide sched_freq_tick() > callback > cpufreq: cppc: Add support for frequency invariance > > arch/arm64/include/asm/topology.h | 8 +- > arch/arm64/kernel/topology.c | 89 +++++++++---------- > drivers/base/arch_topology.c | 56 +++++++++++- > drivers/cpufreq/cppc_cpufreq.c | 140 +++++++++++++++++++++++++++++- > include/linux/arch_topology.h | 14 ++- > kernel/sched/core.c | 1 + > 6 files changed, 244 insertions(+), 64 deletions(-) > > -- > 2.25.0.rc1.19.g042ed3e048af > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel