From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [Intel-gfx] [PATCH v4 09/11] drm/i915: migrate skl planes code new file
Date: Wed, 16 Dec 2020 22:46:27 +0800 [thread overview]
Message-ID: <202012162205.mrd1ggD7-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 8666 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <bd552745b685888a9137d171b5b6acaab8ac7a99.1608117676.git.jani.nikula@intel.com>
References: <bd552745b685888a9137d171b5b6acaab8ac7a99.1608117676.git.jani.nikula@intel.com>
TO: Jani Nikula <jani.nikula@intel.com>
TO: intel-gfx(a)lists.freedesktop.org
CC: jani.nikula(a)intel.com
CC: Dave Airlie <airlied@redhat.com>
Hi Jani,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20201215]
[cannot apply to drm-tip/drm-tip v5.10]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jani-Nikula/drm-i915-refactor-intel-display/20201216-194754
base: git://anongit.freedesktop.org/drm-intel for-linux-next
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
config: x86_64-randconfig-m001-20201216 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/i915/display/intel_gen9_plane.c:712 skl_update_scaler_plane() error: we previously assumed 'fb' could be null (see line 696)
vim +/fb +712 drivers/gpu/drm/i915/display/intel_gen9_plane.c
44f5af76b2fd05e Dave Airlie 2020-12-16 662
44f5af76b2fd05e Dave Airlie 2020-12-16 663 /**
44f5af76b2fd05e Dave Airlie 2020-12-16 664 * skl_update_scaler_plane - Stages update to scaler state for a given plane.
44f5af76b2fd05e Dave Airlie 2020-12-16 665 * @crtc_state: crtc's scaler state
44f5af76b2fd05e Dave Airlie 2020-12-16 666 * @plane_state: atomic plane state to update
44f5af76b2fd05e Dave Airlie 2020-12-16 667 *
44f5af76b2fd05e Dave Airlie 2020-12-16 668 * Return
44f5af76b2fd05e Dave Airlie 2020-12-16 669 * 0 - scaler_usage updated successfully
44f5af76b2fd05e Dave Airlie 2020-12-16 670 * error - requested scaling cannot be supported or other error condition
44f5af76b2fd05e Dave Airlie 2020-12-16 671 */
44f5af76b2fd05e Dave Airlie 2020-12-16 672 int skl_update_scaler_plane(struct intel_crtc_state *crtc_state,
44f5af76b2fd05e Dave Airlie 2020-12-16 673 struct intel_plane_state *plane_state)
44f5af76b2fd05e Dave Airlie 2020-12-16 674 {
44f5af76b2fd05e Dave Airlie 2020-12-16 675 struct intel_plane *intel_plane =
44f5af76b2fd05e Dave Airlie 2020-12-16 676 to_intel_plane(plane_state->uapi.plane);
44f5af76b2fd05e Dave Airlie 2020-12-16 677 struct drm_i915_private *dev_priv = to_i915(intel_plane->base.dev);
44f5af76b2fd05e Dave Airlie 2020-12-16 678 struct drm_framebuffer *fb = plane_state->hw.fb;
44f5af76b2fd05e Dave Airlie 2020-12-16 679 int ret;
44f5af76b2fd05e Dave Airlie 2020-12-16 680 bool force_detach = !fb || !plane_state->uapi.visible;
44f5af76b2fd05e Dave Airlie 2020-12-16 681 bool need_scaler = false;
44f5af76b2fd05e Dave Airlie 2020-12-16 682
44f5af76b2fd05e Dave Airlie 2020-12-16 683 /* Pre-gen11 and SDR planes always need a scaler for planar formats. */
44f5af76b2fd05e Dave Airlie 2020-12-16 684 if (!icl_is_hdr_plane(dev_priv, intel_plane->id) &&
44f5af76b2fd05e Dave Airlie 2020-12-16 685 fb && intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
44f5af76b2fd05e Dave Airlie 2020-12-16 686 need_scaler = true;
44f5af76b2fd05e Dave Airlie 2020-12-16 687
44f5af76b2fd05e Dave Airlie 2020-12-16 688 ret = skl_update_scaler(crtc_state, force_detach,
44f5af76b2fd05e Dave Airlie 2020-12-16 689 drm_plane_index(&intel_plane->base),
44f5af76b2fd05e Dave Airlie 2020-12-16 690 &plane_state->scaler_id,
44f5af76b2fd05e Dave Airlie 2020-12-16 691 drm_rect_width(&plane_state->uapi.src) >> 16,
44f5af76b2fd05e Dave Airlie 2020-12-16 692 drm_rect_height(&plane_state->uapi.src) >> 16,
44f5af76b2fd05e Dave Airlie 2020-12-16 693 drm_rect_width(&plane_state->uapi.dst),
44f5af76b2fd05e Dave Airlie 2020-12-16 694 drm_rect_height(&plane_state->uapi.dst),
44f5af76b2fd05e Dave Airlie 2020-12-16 695 fb ? fb->format : NULL,
44f5af76b2fd05e Dave Airlie 2020-12-16 @696 fb ? fb->modifier : 0,
44f5af76b2fd05e Dave Airlie 2020-12-16 697 need_scaler);
44f5af76b2fd05e Dave Airlie 2020-12-16 698
44f5af76b2fd05e Dave Airlie 2020-12-16 699 if (ret || plane_state->scaler_id < 0)
44f5af76b2fd05e Dave Airlie 2020-12-16 700 return ret;
44f5af76b2fd05e Dave Airlie 2020-12-16 701
44f5af76b2fd05e Dave Airlie 2020-12-16 702 /* check colorkey */
44f5af76b2fd05e Dave Airlie 2020-12-16 703 if (plane_state->ckey.flags) {
44f5af76b2fd05e Dave Airlie 2020-12-16 704 drm_dbg_kms(&dev_priv->drm,
44f5af76b2fd05e Dave Airlie 2020-12-16 705 "[PLANE:%d:%s] scaling with color key not allowed",
44f5af76b2fd05e Dave Airlie 2020-12-16 706 intel_plane->base.base.id,
44f5af76b2fd05e Dave Airlie 2020-12-16 707 intel_plane->base.name);
44f5af76b2fd05e Dave Airlie 2020-12-16 708 return -EINVAL;
44f5af76b2fd05e Dave Airlie 2020-12-16 709 }
44f5af76b2fd05e Dave Airlie 2020-12-16 710
44f5af76b2fd05e Dave Airlie 2020-12-16 711 /* Check src format */
44f5af76b2fd05e Dave Airlie 2020-12-16 @712 switch (fb->format->format) {
44f5af76b2fd05e Dave Airlie 2020-12-16 713 case DRM_FORMAT_RGB565:
44f5af76b2fd05e Dave Airlie 2020-12-16 714 case DRM_FORMAT_XBGR8888:
44f5af76b2fd05e Dave Airlie 2020-12-16 715 case DRM_FORMAT_XRGB8888:
44f5af76b2fd05e Dave Airlie 2020-12-16 716 case DRM_FORMAT_ABGR8888:
44f5af76b2fd05e Dave Airlie 2020-12-16 717 case DRM_FORMAT_ARGB8888:
44f5af76b2fd05e Dave Airlie 2020-12-16 718 case DRM_FORMAT_XRGB2101010:
44f5af76b2fd05e Dave Airlie 2020-12-16 719 case DRM_FORMAT_XBGR2101010:
44f5af76b2fd05e Dave Airlie 2020-12-16 720 case DRM_FORMAT_ARGB2101010:
44f5af76b2fd05e Dave Airlie 2020-12-16 721 case DRM_FORMAT_ABGR2101010:
44f5af76b2fd05e Dave Airlie 2020-12-16 722 case DRM_FORMAT_YUYV:
44f5af76b2fd05e Dave Airlie 2020-12-16 723 case DRM_FORMAT_YVYU:
44f5af76b2fd05e Dave Airlie 2020-12-16 724 case DRM_FORMAT_UYVY:
44f5af76b2fd05e Dave Airlie 2020-12-16 725 case DRM_FORMAT_VYUY:
44f5af76b2fd05e Dave Airlie 2020-12-16 726 case DRM_FORMAT_NV12:
44f5af76b2fd05e Dave Airlie 2020-12-16 727 case DRM_FORMAT_XYUV8888:
44f5af76b2fd05e Dave Airlie 2020-12-16 728 case DRM_FORMAT_P010:
44f5af76b2fd05e Dave Airlie 2020-12-16 729 case DRM_FORMAT_P012:
44f5af76b2fd05e Dave Airlie 2020-12-16 730 case DRM_FORMAT_P016:
44f5af76b2fd05e Dave Airlie 2020-12-16 731 case DRM_FORMAT_Y210:
44f5af76b2fd05e Dave Airlie 2020-12-16 732 case DRM_FORMAT_Y212:
44f5af76b2fd05e Dave Airlie 2020-12-16 733 case DRM_FORMAT_Y216:
44f5af76b2fd05e Dave Airlie 2020-12-16 734 case DRM_FORMAT_XVYU2101010:
44f5af76b2fd05e Dave Airlie 2020-12-16 735 case DRM_FORMAT_XVYU12_16161616:
44f5af76b2fd05e Dave Airlie 2020-12-16 736 case DRM_FORMAT_XVYU16161616:
44f5af76b2fd05e Dave Airlie 2020-12-16 737 break;
44f5af76b2fd05e Dave Airlie 2020-12-16 738 case DRM_FORMAT_XBGR16161616F:
44f5af76b2fd05e Dave Airlie 2020-12-16 739 case DRM_FORMAT_ABGR16161616F:
44f5af76b2fd05e Dave Airlie 2020-12-16 740 case DRM_FORMAT_XRGB16161616F:
44f5af76b2fd05e Dave Airlie 2020-12-16 741 case DRM_FORMAT_ARGB16161616F:
44f5af76b2fd05e Dave Airlie 2020-12-16 742 if (INTEL_GEN(dev_priv) >= 11)
44f5af76b2fd05e Dave Airlie 2020-12-16 743 break;
44f5af76b2fd05e Dave Airlie 2020-12-16 744 fallthrough;
44f5af76b2fd05e Dave Airlie 2020-12-16 745 default:
44f5af76b2fd05e Dave Airlie 2020-12-16 746 drm_dbg_kms(&dev_priv->drm,
44f5af76b2fd05e Dave Airlie 2020-12-16 747 "[PLANE:%d:%s] FB:%d unsupported scaling format 0x%x\n",
44f5af76b2fd05e Dave Airlie 2020-12-16 748 intel_plane->base.base.id, intel_plane->base.name,
44f5af76b2fd05e Dave Airlie 2020-12-16 749 fb->base.id, fb->format->format);
44f5af76b2fd05e Dave Airlie 2020-12-16 750 return -EINVAL;
44f5af76b2fd05e Dave Airlie 2020-12-16 751 }
44f5af76b2fd05e Dave Airlie 2020-12-16 752
44f5af76b2fd05e Dave Airlie 2020-12-16 753 return 0;
44f5af76b2fd05e Dave Airlie 2020-12-16 754 }
44f5af76b2fd05e Dave Airlie 2020-12-16 755
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32945 bytes --]
next reply other threads:[~2020-12-16 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 14:46 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-12-16 11:29 [Intel-gfx] [PATCH v4 00/11] drm/i915: refactor intel display Jani Nikula
2020-12-16 11:29 ` [Intel-gfx] [PATCH v4 09/11] drm/i915: migrate skl planes code new file Jani Nikula
2020-12-16 12:11 ` Ville Syrjälä
2020-12-16 15:21 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012162205.mrd1ggD7-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.