Re: [PATCH V2] xfsdump: don't try to generate .ltdep in inventory/

[Bill O'Donnell <billodo@redhat.com>]

On Wed, Dec 16, 2020 at 04:32:07PM -0600, Eric Sandeen wrote:
> .ltdep gets generated from CFILES, and there are none in inventory/
> so trying to generate it in that dir leads to a non-fatal error when
> the include invokes the rule to build the .ltdep file:
> 
> Building inventory
>     [LTDEP]
> gcc: fatal error: no input files
> compilation terminated.
> 
> inventory/ - like common/ - has files that get linked into other dirs,
> and .ltdep is generated in those other dirs, not in inventory/.
> 
> So, simply remove the .ltdep include/generation from the inventory/
> dir, because there is no reason or ability to generate the file here.
> 
> Reported-by: Thomas Deutschmann <whissi@gentoo.org>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Reviewed-by: Bill O'Donnell <billodo@redhat.com>

> ---
> 
> V2: more comprehensive problem description
> 
> diff --git a/inventory/Makefile b/inventory/Makefile
> index cda145e..6624fba 100644
> --- a/inventory/Makefile
> +++ b/inventory/Makefile
> @@ -12,5 +12,3 @@ LSRCFILES = inv_api.c inv_core.c inv_fstab.c inv_idx.c inv_mgr.c \
>  default install install-dev:
>  
>  include $(BUILDRULES)
> -
> --include .ltdep
>