Re: [Intel-gfx] [PATCH v4 05/11] drm/i915: refactor some crtc code out of intel display.

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2358 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <72e2f24020bb18931b34f990372636e2c67ebd5d.1608117676.git.jani.nikula@intel.com>
References: <72e2f24020bb18931b34f990372636e2c67ebd5d.1608117676.git.jani.nikula@intel.com>
TO: Jani Nikula <jani.nikula@intel.com>
TO: intel-gfx(a)lists.freedesktop.org
CC: jani.nikula(a)intel.com
CC: Dave Airlie <airlied@redhat.com>

Hi Jani,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20201215]
[cannot apply to drm-tip/drm-tip v5.10]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jani-Nikula/drm-i915-refactor-intel-display/20201216-194754
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago
config: i386-randconfig-m021-20201216 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/gpu/drm/i915/display/intel_crtc.c:869 intel_crtc_init() warn: passing a valid pointer to 'PTR_ERR'

vim +/PTR_ERR +869 drivers/gpu/drm/i915/display/intel_crtc.c

48148b2af754d91 Dave Airlie 2020-12-16  859  
48148b2af754d91 Dave Airlie 2020-12-16  860  int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
48148b2af754d91 Dave Airlie 2020-12-16  861  {
48148b2af754d91 Dave Airlie 2020-12-16  862  	struct intel_plane *primary, *cursor;
48148b2af754d91 Dave Airlie 2020-12-16  863  	const struct drm_crtc_funcs *funcs;
48148b2af754d91 Dave Airlie 2020-12-16  864  	struct intel_crtc *crtc;
48148b2af754d91 Dave Airlie 2020-12-16  865  	int sprite, ret;
48148b2af754d91 Dave Airlie 2020-12-16  866  
48148b2af754d91 Dave Airlie 2020-12-16  867  	crtc = intel_crtc_alloc();
48148b2af754d91 Dave Airlie 2020-12-16  868  	if (IS_ERR(crtc))
48148b2af754d91 Dave Airlie 2020-12-16 @869  		return PTR_ERR(crtc);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32439 bytes --]