All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Stephen Liang <stephenliang7@gmail.com>,
	wink@technolu.st, Jeffrey Hugo <jhugo@codeaurora.org>,
	Carl Huang <cjhuang@codeaurora.org>,
	Bhaumik Bhatt <bbhatt@codeaurora.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Hemant Kumar <hemantk@codeaurora.org>,
	ath11k@lists.infradead.org,
	Mitchell Nordine <mail@mitchellnordine.com>
Subject: Re: ath11k: crashes with 1 MSI vector, workaround disable MHI M2 state
Date: Thu, 17 Dec 2020 15:23:02 +0530	[thread overview]
Message-ID: <20201217095302.GA4640@work> (raw)
In-Reply-To: <87pn3axhm1.fsf@codeaurora.org>

Hi Kalle,

On Wed, Dec 16, 2020 at 10:47:18AM +0200, Kalle Valo wrote:
> Hi MHI devs,
> 

[...]

> After extensive debugging from wink he found out that disabling M2 state
> makes the all problems go away:
> 
> --- a/drivers/bus/mhi/core/pm.c
> +++ b/drivers/bus/mhi/core/pm.c
> @@ -55,12 +55,12 @@ static struct mhi_pm_transitions const dev_state_transitions[] = {
>         },
>         {
>                 MHI_PM_M0,
> -               MHI_PM_M0 | MHI_PM_M2 | MHI_PM_M3_ENTER |
> +               MHI_PM_M0 | MHI_PM_M3_ENTER |
>                 MHI_PM_SYS_ERR_DETECT | MHI_PM_SHUTDOWN_PROCESS |
>                 MHI_PM_LD_ERR_FATAL_DETECT | MHI_PM_FW_DL_ERR
>         },
>         {
> -               MHI_PM_M2,
> +               MHI_PM_M0,
>                 MHI_PM_M0 | MHI_PM_SYS_ERR_DETECT | MHI_PM_SHUTDOWN_PROCESS |
>                 MHI_PM_LD_ERR_FATAL_DETECT
>         },
> 
> And indeed now we have numerous people reporting that with this
> workaround ath11k is stable on their Dell XPS 13 9310 laptops. What on
> earth could cause these kernel crashes/interrupt storms? And why is it
> visible only on Dell laptops? Why does disabling M2 state fix it?
> 

This is related to the ASPM state of the PCIe bus. In the meantime, I'd
suggest to turn off ASPM using "pcie_aspm=off" in the kernel command
line so that the MHI bus stays in M0.

For debugging this issue, can someone enable debug logs for MHI and share
the dmesg output (with ASPM enabled ofc)?

Thanks,
Mani

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  parent reply	other threads:[~2020-12-17  9:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16  8:47 ath11k: crashes with 1 MSI vector, workaround disable MHI M2 state Kalle Valo
2020-12-17  8:41 ` Kalle Valo
2020-12-17  9:53 ` Manivannan Sadhasivam [this message]
2020-12-17 19:01   ` Stephen Liang
2020-12-19 21:34   ` wi nk
2020-12-20 15:05     ` Manivannan Sadhasivam
2020-12-20 15:39       ` wi nk
2020-12-21 17:15         ` Kalle Valo
2020-12-21 17:26           ` wi nk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201217095302.GA4640@work \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=ath11k@lists.infradead.org \
    --cc=bbhatt@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=cjhuang@codeaurora.org \
    --cc=hemantk@codeaurora.org \
    --cc=jhugo@codeaurora.org \
    --cc=kvalo@codeaurora.org \
    --cc=mail@mitchellnordine.com \
    --cc=stephenliang7@gmail.com \
    --cc=wink@technolu.st \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.