From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:4c03:0:0:0:0:0 with SMTP id t3csp1340401lfq; Thu, 17 Dec 2020 06:38:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJwKQeHVMyqPRakC/iR5qOvC3iGTG9bTeEAhiOsTBP80a1DLie/xI7GQhcHbsJBuxDqtjQNl X-Received: by 2002:a25:6853:: with SMTP id d80mr53733438ybc.47.1608215893598; Thu, 17 Dec 2020 06:38:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608215893; cv=none; d=google.com; s=arc-20160816; b=KjvGos9YoUPoJbrRunLyOmwcV0VU/WedfQf+m2XCUGxHKQyqD45Q+JArurqV6aAG81 wQMctsJoIW7pL1L/0KbO4ULdffOYPpwIj3wqHDoXqCS2zDxc5eGsmFujw0DPDD6+lqdk gwvbK4j8MwFhrJYVFXc5lr7aPtrebva1ZPYG+CFN2sbdITERUTiE87syZ6L1cwamrT07 kS3t5ilRatLGyhJZJsfF58/BrE1lX0/yV7z7QWQbwrxY6/EYST2ZE+6tce/d3YaUtGRz KR1ra6DG4qc93Dtb2xocrcs0j0iV2SxRyEKGIr9MF/0N/H+K2RH3mBuBoTQ5wOsZJZi0 Hzfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-disposition:in-reply-to :mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=s3dIxyTS8y3OicPT8ExvIWlNk6sXUNBdh3LfqSfY1dA=; b=sFQ9f7uO7TV5UzUYnhq7+Nw1wwHT6+cU84d0NaY3o2o9WjthPSXUPYZ7+fmBjvOilx HLNplYrEuakc8VlQTmtyPB6xtZcIcD7fuxhY+nlkEjdFcxfLc6WLYxTKcdTxWFl2o44L BcENpVtg2Y1QfB/jMzc2WKc1R8Dw/bDUoAaHUG17Gly1adtzpqPs2kENRuvwcGKuHjA2 bT9KO/taEKt8jGNp1NiLL7IkFuAuoQvKPCimklNCQyJbb8K+EHBmu1W6Q61MydNANpZ0 LfQP6qphlRruUdWr0Czd7V/0D08s6SrAhqICRJBQWf9gRKt6GYYTXt30x5KKKpCqMkJl oP0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=A2cQs2md; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p66si5276016yba.244.2020.12.17.06.38.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Dec 2020 06:38:13 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=A2cQs2md; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:42266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpuQ0-0005fP-Tv for alex.bennee@linaro.org; Thu, 17 Dec 2020 09:38:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpuP0-0005eD-IP for qemu-devel@nongnu.org; Thu, 17 Dec 2020 09:37:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31253) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kpuOv-0007qz-0f for qemu-devel@nongnu.org; Thu, 17 Dec 2020 09:37:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608215821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s3dIxyTS8y3OicPT8ExvIWlNk6sXUNBdh3LfqSfY1dA=; b=A2cQs2mdsz9beqYZc2ErcFACgix9tFU90gmwMLzFi5/VxkQBIpE/uCsFxyFQQGfrvxOWPs dR7BOm195Flxr2YreLFE/u3s/kc2QxbkPWMKpqvAdY4lTA5t6Nb4Erw2SfzYgJF+acYdKT reXfBEqi5kppdsVuI3zRsyqFT0B+9fo= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-359-hvZOFeL4NHqiZoq5lUYZ2Q-1; Thu, 17 Dec 2020 09:36:55 -0500 X-MC-Unique: hvZOFeL4NHqiZoq5lUYZ2Q-1 Received: by mail-qt1-f198.google.com with SMTP id e14so20841002qtr.8 for ; Thu, 17 Dec 2020 06:36:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=s3dIxyTS8y3OicPT8ExvIWlNk6sXUNBdh3LfqSfY1dA=; b=YlBsQP72HfUGB+h6rS4nFON5nA7Zy4loXHosPNTa/HQmOQ/rvwb0fR0uLWnJb1tvUc P8PO5XkwrfNuHnFpG2wilPfwplYaoddCQN19ob3BHMTbQKFbhFiEj17i4IpcNQXFw1eJ LcxJS18lCb6K7SPo/U6VVJnur1stl/rf1At1ajMqQdKn7hUOVbYWS2Dyi8Cfhu+8f2rN cj771EhhZyUSfei4dXWrxJLwNFQKtLEG+Bc1yADdhmESyXpHZZYnOO27ck1+fvl3FLdr Tw8jtD3PGSuG2WRX/PNQCW+BRfeY7aVNd8n12eBaiwYlzONICp6TotG9V6Ag46qBYxvZ dfQA== X-Gm-Message-State: AOAM531M2w2YFXhoCpeBgoA9+HhKga2DmSm++TW2S2f1+SzMJ9MxyXSO vFn90lFR6CBOX/7EcLZ+G3iU6W5iwzAojegdo5UgvH0cLwQ6ahz0pQn8STR4bDlvn2hJWhq+O+Z I1jWVjuuBIePZHkM= X-Received: by 2002:a05:6214:80d:: with SMTP id df13mr49747205qvb.10.1608215815265; Thu, 17 Dec 2020 06:36:55 -0800 (PST) X-Received: by 2002:a05:6214:80d:: with SMTP id df13mr49747180qvb.10.1608215815054; Thu, 17 Dec 2020 06:36:55 -0800 (PST) Received: from xz-x1 ([142.126.83.202]) by smtp.gmail.com with ESMTPSA id s11sm3519531qkm.124.2020.12.17.06.36.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Dec 2020 06:36:54 -0800 (PST) Date: Thu, 17 Dec 2020 09:36:52 -0500 From: Peter Xu To: Keqian Zhu Subject: Re: [PATCH v2 2/2] accel: kvm: Add aligment assert for kvm_log_clear_one_slot Message-ID: <20201217143652.GC39844@xz-x1> References: <20201217014941.22872-1-zhukeqian1@huawei.com> <20201217014941.22872-3-zhukeqian1@huawei.com> MIME-Version: 1.0 In-Reply-To: <20201217014941.22872-3-zhukeqian1@huawei.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrew Jones , jiangkunkun@huawei.com, qemu-devel@nongnu.org, "Dr . David Alan Gilbert" , qemu-arm@nongnu.org, wanghaibin.wang@huawei.com, Zenghui Yu , Paolo Bonzini Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: QOukFBlTAJfy On Thu, Dec 17, 2020 at 09:49:41AM +0800, Keqian Zhu wrote: > The parameters start and size are transfered from QEMU memory > emulation layer. It can promise that they are TARGET_PAGE_SIZE > aligned. However, KVM needs they are qemu_real_page_size aligned. > > Though no caller breaks this aligned requirement currently, we'd > better add an explicit assert to avoid future breaking. > > Signed-off-by: Keqian Zhu Acked-by: Peter Xu -- Peter Xu