From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: kvalo@codeaurora.org
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mt76: sdio: remove wake logic in mt76s_process_tx_queue
Date: Thu, 17 Dec 2020 20:07:53 +0100 [thread overview]
Message-ID: <20201217190753.GF16606@lore-desk> (raw)
In-Reply-To: <d2d7d9d437f4dec2ef1df0ed070b9cf299f021ad.1607164041.git.lorenzo@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1666 bytes --]
> Similar to mmio/usb code path, remove wake logic in mt76s_process_tx_queue
> routine
Starting from commit '90d494c99a99fa2eb858754345c4a9c851b409a0
("mt76: improve tx queue stop/wake")', the wake queue logic on
the sdio status path is no longer necessary since the hw queues
are no longer stopped on the mt76 tx path.
Regards,
Lorenzo
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> drivers/net/wireless/mediatek/mt76/sdio.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/sdio.c b/drivers/net/wireless/mediatek/mt76/sdio.c
> index 62b5b912818f..7cd995118257 100644
> --- a/drivers/net/wireless/mediatek/mt76/sdio.c
> +++ b/drivers/net/wireless/mediatek/mt76/sdio.c
> @@ -157,7 +157,7 @@ static void mt76s_net_worker(struct mt76_worker *w)
>
> static int mt76s_process_tx_queue(struct mt76_dev *dev, struct mt76_queue *q)
> {
> - bool wake, mcu = q == dev->q_mcu[MT_MCUQ_WM];
> + bool mcu = q == dev->q_mcu[MT_MCUQ_WM];
> struct mt76_queue_entry entry;
> int nframes = 0;
>
> @@ -177,21 +177,12 @@ static int mt76s_process_tx_queue(struct mt76_dev *dev, struct mt76_queue *q)
> nframes++;
> }
>
> - wake = q->stopped && q->queued < q->ndesc - 8;
> - if (wake)
> - q->stopped = false;
> -
> if (!q->queued)
> wake_up(&dev->tx_wait);
>
> - if (mcu)
> - goto out;
> -
> - mt76_txq_schedule(&dev->phy, q->qid);
> + if (!mcu)
> + mt76_txq_schedule(&dev->phy, q->qid);
>
> - if (wake)
> - ieee80211_wake_queue(dev->hw, q->qid);
> -out:
> return nframes;
> }
>
> --
> 2.28.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-12-17 19:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 10:35 [PATCH 0/2] remove wake queue tx logic for usb/sdio Lorenzo Bianconi
2020-12-05 10:35 ` [PATCH 1/2] mt76: usb: remove wake logic in mt76u_status_worker Lorenzo Bianconi
2020-12-17 19:10 ` Lorenzo Bianconi
2020-12-18 5:26 ` Kalle Valo
2020-12-20 12:04 ` [1/2] " Kalle Valo
2020-12-05 10:35 ` [PATCH 2/2] mt76: sdio: remove wake logic in mt76s_process_tx_queue Lorenzo Bianconi
2020-12-17 19:07 ` Lorenzo Bianconi [this message]
2020-12-17 12:03 ` [PATCH 0/2] remove wake queue tx logic for usb/sdio Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217190753.GF16606@lore-desk \
--to=lorenzo.bianconi@redhat.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.