From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Alex Chen <alex.chen@huawei.com>,
qemu-trivial@nongnu.org, zhang.zhanghailiang@huawei.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH] virtiofsd: Remove useless code about send_notify_iov
Date: Thu, 17 Dec 2020 20:09:07 +0000 [thread overview]
Message-ID: <20201217200907.GA43032@work-vm> (raw)
In-Reply-To: <20201214170045.GI620320@stefanha-x1.localdomain>
* Stefan Hajnoczi (stefanha@redhat.com) wrote:
> On Mon, Dec 14, 2020 at 12:16:15PM +0000, Alex Chen wrote:
> > The 'ch' will be NULL in the following stack:
> > send_notify_iov()->fuse_send_msg()->virtio_send_msg(), and
> > this may lead to NULL pointer dereferenced in virtio_send_msg().
> > But send_notify_iov() was never called, so remove the useless code
> > about send_notify_iov() to fix this problem.
> >
> > Signed-off-by: Alex Chen <alex.chen@huawei.com>
> > ---
> > tools/virtiofsd/fuse_lowlevel.c | 98 ---------------------------------
> > 1 file changed, 98 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
I've picked this up in my current virtiofsd pull I'm doing.
Queued
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2020-12-17 20:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 12:16 [PATCH] virtiofsd: Remove useless code about send_notify_iov Alex Chen
2020-12-14 12:16 ` Alex Chen
2020-12-14 17:00 ` Stefan Hajnoczi
2020-12-14 17:00 ` Stefan Hajnoczi
2020-12-17 20:09 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217200907.GA43032@work-vm \
--to=dgilbert@redhat.com \
--cc=alex.chen@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.