All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org,
	"Andreas Kemnade" <andreas@kemnade.info>,
	stable@vger.kernel.org
Subject: Re: [PATCH] DTS: ARM: gta04: remove legacy spi-cs-high to make display work again
Date: Fri, 18 Dec 2020 09:12:55 +0200	[thread overview]
Message-ID: <20201218071255.GD26857@atomide.com> (raw)
In-Reply-To: <de8774e44a8f6402435e64034b8e7122157f5b52.1607766924.git.hns@goldelico.com>

* H. Nikolaus Schaller <hns@goldelico.com> [201212 11:59]:
> This reverts
> 
> commit f1f028ff89cb ("DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again")
> 
> which had to be intruduced after
> 
> commit 6953c57ab172 ("gpio: of: Handle SPI chipselect legacy bindings")
> 
> broke the GTA04 display. This contradicted the data sheet but was the only
> way to get it as an spi client operational again.
> 
> The panel data sheet defines the chip-select to be active low.
> 
> Now, with the arrival of
> 
> commit 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")
> 
> the logic of interaction between spi-cs-high and the gpio descriptor flags
> has been changed a second time, making the display broken again. So we have
> to remove the original fix which in retrospect was a workaround of a bug in
> the spi subsystem and not a feature of the panel or bug in the device tree.
> 
> With this fix the device tree is back in sync with the data sheet and
> spi subsystem code.

Thanks applying into fixes.

Tony

      reply	other threads:[~2020-12-18  7:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-12  9:55 [PATCH] DTS: ARM: gta04: remove legacy spi-cs-high to make display work again H. Nikolaus Schaller
2020-12-18  7:12 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201218071255.GD26857@atomide.com \
    --to=tony@atomide.com \
    --cc=andreas@kemnade.info \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hns@goldelico.com \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.