From: Kees Cook <keescook@chromium.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Bhaskara Budiredla <bbudiredla@marvell.com>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [EXT] Re: [PATCH 1/2] mmc: Support kmsg dumper based on pstore/blk
Date: Fri, 18 Dec 2020 10:50:25 -0800 [thread overview]
Message-ID: <202012181047.99F11364@keescook> (raw)
In-Reply-To: <CAPDyKFp=T2uqWsSTij_K=yXSffpPOKcWTqNrVxfatkncCZzaMQ@mail.gmail.com>
On Wed, Dec 16, 2020 at 11:44:26AM +0100, Ulf Hansson wrote:
> In any case, I didn't catch *why* pstore needs to force block device
> drivers to implement specific pstore hooks to support the pstore file
> system. I don't think this is the way it should work, for many
For panic, pstore must avoid any path that might sleep. In a perfect
world, it should also use as little code as possible, to avoid
potentially tripping over areas of the kernel that might be broken.
--
Kees Cook
next prev parent reply other threads:[~2020-12-18 18:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 11:57 [PATCH v3 0/2] mmc: support crash logging to MMC block devices Bhaskara Budiredla
2020-12-07 11:57 ` [PATCH 1/2] mmc: Support kmsg dumper based on pstore/blk Bhaskara Budiredla
2020-12-11 11:31 ` Ulf Hansson
2020-12-15 6:52 ` [EXT] " Bhaskara Budiredla
2020-12-15 11:42 ` Ulf Hansson
2020-12-15 14:34 ` Bhaskara Budiredla
2020-12-16 9:57 ` Ulf Hansson
2020-12-16 10:42 ` Bhaskara Budiredla
2020-12-16 10:52 ` Ulf Hansson
2020-12-17 11:36 ` Bhaskara Budiredla
2020-12-17 17:11 ` Ulf Hansson
2020-12-18 4:02 ` Bhaskara Budiredla
2020-12-15 20:37 ` Kees Cook
2020-12-16 10:44 ` Ulf Hansson
2020-12-18 18:50 ` Kees Cook [this message]
2020-12-07 11:57 ` [PATCH 2/2] mmc: cavium: Add MMC polling method to support kmsg panic/oops write Bhaskara Budiredla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012181047.99F11364@keescook \
--to=keescook@chromium.org \
--cc=bbudiredla@marvell.com \
--cc=ccross@android.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sgoutham@marvell.com \
--cc=tony.luck@intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.