From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [zanussi-trace:ftrace/synth-fixes-v4 4/5] kernel/trace/trace_events_synth.c:1564 insert_semicolons() error: uninitialized symbol 'save_argv'.
Date: Fri, 18 Dec 2020 11:06:11 +0800 [thread overview]
Message-ID: <202012181106.bGRbdoPz-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 6207 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Tom Zanussi <zanussi@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/synth-fixes-v4
head: 6cb978ea1a56e76f723fb7aee74422b0766db8e9
commit: 10708db9327a6db3e8cdd9639504923e6629ae85 [4/5] tracing: Add a backward-compatibility check for synthetic event creation
:::::: branch date: 8 hours ago
:::::: commit date: 8 hours ago
config: i386-randconfig-m021-20201217 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
kernel/trace/trace_events_synth.c:1564 insert_semicolons() error: uninitialized symbol 'save_argv'.
kernel/trace/trace_events_synth.c:1566 insert_semicolons() error: uninitialized symbol 'buf'.
vim +/save_argv +1564 kernel/trace/trace_events_synth.c
10708db9327a6db Tom Zanussi 2020-12-14 1492
10708db9327a6db Tom Zanussi 2020-12-14 1493 static char *insert_semicolons(const char *raw_command)
10708db9327a6db Tom Zanussi 2020-12-14 1494 {
10708db9327a6db Tom Zanussi 2020-12-14 1495 int i, argc, consumed = 0, n_fields = 0, semis_added = 0;
10708db9327a6db Tom Zanussi 2020-12-14 1496 char *name, **argv, **save_argv;
10708db9327a6db Tom Zanussi 2020-12-14 1497 int ret = -EINVAL;
10708db9327a6db Tom Zanussi 2020-12-14 1498 struct seq_buf s;
10708db9327a6db Tom Zanussi 2020-12-14 1499 bool added_semi;
10708db9327a6db Tom Zanussi 2020-12-14 1500 char *buf;
10708db9327a6db Tom Zanussi 2020-12-14 1501
10708db9327a6db Tom Zanussi 2020-12-14 1502 argc = 0;
10708db9327a6db Tom Zanussi 2020-12-14 1503
10708db9327a6db Tom Zanussi 2020-12-14 1504 argv = argv_split(GFP_KERNEL, raw_command, &argc);
10708db9327a6db Tom Zanussi 2020-12-14 1505 if (!argv)
10708db9327a6db Tom Zanussi 2020-12-14 1506 return NULL;
10708db9327a6db Tom Zanussi 2020-12-14 1507
10708db9327a6db Tom Zanussi 2020-12-14 1508 if (!argc)
10708db9327a6db Tom Zanussi 2020-12-14 1509 goto out;
10708db9327a6db Tom Zanussi 2020-12-14 1510
10708db9327a6db Tom Zanussi 2020-12-14 1511 name = argv[0];
10708db9327a6db Tom Zanussi 2020-12-14 1512 save_argv = argv;
10708db9327a6db Tom Zanussi 2020-12-14 1513 argv++;
10708db9327a6db Tom Zanussi 2020-12-14 1514 argc--;
10708db9327a6db Tom Zanussi 2020-12-14 1515
10708db9327a6db Tom Zanussi 2020-12-14 1516 buf = kzalloc(MAX_DYNEVENT_CMD_LEN, GFP_KERNEL);
10708db9327a6db Tom Zanussi 2020-12-14 1517 if (!buf) {
10708db9327a6db Tom Zanussi 2020-12-14 1518 ret = -ENOMEM;
10708db9327a6db Tom Zanussi 2020-12-14 1519 goto err;
10708db9327a6db Tom Zanussi 2020-12-14 1520 }
10708db9327a6db Tom Zanussi 2020-12-14 1521
10708db9327a6db Tom Zanussi 2020-12-14 1522 seq_buf_init(&s, buf, MAX_DYNEVENT_CMD_LEN);
10708db9327a6db Tom Zanussi 2020-12-14 1523
10708db9327a6db Tom Zanussi 2020-12-14 1524 seq_buf_puts(&s, name);
10708db9327a6db Tom Zanussi 2020-12-14 1525 seq_buf_putc(&s, ' ');
10708db9327a6db Tom Zanussi 2020-12-14 1526
10708db9327a6db Tom Zanussi 2020-12-14 1527 if (name[0] == '\0' || argc < 1)
10708db9327a6db Tom Zanussi 2020-12-14 1528 goto err;
10708db9327a6db Tom Zanussi 2020-12-14 1529
10708db9327a6db Tom Zanussi 2020-12-14 1530 for (i = 0; i < argc - 1; i++) {
10708db9327a6db Tom Zanussi 2020-12-14 1531 if (strcmp(argv[i], ";") == 0) {
10708db9327a6db Tom Zanussi 2020-12-14 1532 seq_buf_puts(&s, " ; ");
10708db9327a6db Tom Zanussi 2020-12-14 1533 continue;
10708db9327a6db Tom Zanussi 2020-12-14 1534 }
10708db9327a6db Tom Zanussi 2020-12-14 1535
10708db9327a6db Tom Zanussi 2020-12-14 1536 if (n_fields == SYNTH_FIELDS_MAX)
10708db9327a6db Tom Zanussi 2020-12-14 1537 goto err;
10708db9327a6db Tom Zanussi 2020-12-14 1538
10708db9327a6db Tom Zanussi 2020-12-14 1539 ret = save_synth_field(argc - i, &argv[i], &consumed,
10708db9327a6db Tom Zanussi 2020-12-14 1540 &s, &added_semi);
10708db9327a6db Tom Zanussi 2020-12-14 1541 if (ret)
10708db9327a6db Tom Zanussi 2020-12-14 1542 goto err;
10708db9327a6db Tom Zanussi 2020-12-14 1543
10708db9327a6db Tom Zanussi 2020-12-14 1544 if (added_semi)
10708db9327a6db Tom Zanussi 2020-12-14 1545 semis_added++;
10708db9327a6db Tom Zanussi 2020-12-14 1546
10708db9327a6db Tom Zanussi 2020-12-14 1547 i += consumed - 1;
10708db9327a6db Tom Zanussi 2020-12-14 1548 }
10708db9327a6db Tom Zanussi 2020-12-14 1549
10708db9327a6db Tom Zanussi 2020-12-14 1550 if (i < argc && strcmp(argv[i], ";") != 0)
10708db9327a6db Tom Zanussi 2020-12-14 1551 goto err;
10708db9327a6db Tom Zanussi 2020-12-14 1552
10708db9327a6db Tom Zanussi 2020-12-14 1553 if (!semis_added) {
10708db9327a6db Tom Zanussi 2020-12-14 1554 kfree(buf);
10708db9327a6db Tom Zanussi 2020-12-14 1555 buf = NULL;
10708db9327a6db Tom Zanussi 2020-12-14 1556 goto out;
10708db9327a6db Tom Zanussi 2020-12-14 1557 }
10708db9327a6db Tom Zanussi 2020-12-14 1558
10708db9327a6db Tom Zanussi 2020-12-14 1559 if (WARN_ON_ONCE(!seq_buf_buffer_left(&s)))
10708db9327a6db Tom Zanussi 2020-12-14 1560 goto err;
10708db9327a6db Tom Zanussi 2020-12-14 1561
10708db9327a6db Tom Zanussi 2020-12-14 1562 buf[s.len] = '\0';
10708db9327a6db Tom Zanussi 2020-12-14 1563 out:
10708db9327a6db Tom Zanussi 2020-12-14 @1564 argv_free(save_argv);
10708db9327a6db Tom Zanussi 2020-12-14 1565
10708db9327a6db Tom Zanussi 2020-12-14 @1566 return buf;
10708db9327a6db Tom Zanussi 2020-12-14 1567 err:
10708db9327a6db Tom Zanussi 2020-12-14 1568 kfree(buf);
10708db9327a6db Tom Zanussi 2020-12-14 1569 buf = ERR_PTR(ret);
10708db9327a6db Tom Zanussi 2020-12-14 1570
10708db9327a6db Tom Zanussi 2020-12-14 1571 goto out;
10708db9327a6db Tom Zanussi 2020-12-14 1572 }
10708db9327a6db Tom Zanussi 2020-12-14 1573
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33027 bytes --]
next reply other threads:[~2020-12-18 3:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 3:06 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-12-18 11:13 [zanussi-trace:ftrace/synth-fixes-v4 4/5] kernel/trace/trace_events_synth.c:1564 insert_semicolons() error: uninitialized symbol 'save_argv' Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012181106.bGRbdoPz-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.