Re: [PATCH v9 01/26] PCI: Fix race condition in pci_enable/disable_device()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2655 bytes --]

Hi Sergei,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on a409ed156a90093a03fe6a93721ddf4c591eac87]

url:    https://github.com/0day-ci/linux/commits/Sergei-Miroshnichenko/PCI-Allow-BAR-movement-during-boot-and-hotplug/20201219-014810
base:    a409ed156a90093a03fe6a93721ddf4c591eac87
config: powerpc-randconfig-r036-20201218 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project cee1e7d14f4628d6174b33640d502bff3b54ae45)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc cross compiling tool for clang build
        # apt-get install binutils-powerpc-linux-gnu
        # https://github.com/0day-ci/linux/commit/2459b758d22bc2c5d20ddcbd857613a624cfecdd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sergei-Miroshnichenko/PCI-Allow-BAR-movement-during-boot-and-hotplug/20201219-014810
        git checkout 2459b758d22bc2c5d20ddcbd857613a624cfecdd
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/pci/pci.c:1864:40: error: implicit declaration of function 'pci_bridge_depth' [-Werror,-Wimplicit-function-declaration]
           mutex_lock_nested(&dev->enable_mutex, pci_bridge_depth(dev));
                                                 ^
   1 error generated.


vim +/pci_bridge_depth +1864 drivers/pci/pci.c

  1858	
  1859	static void pci_enable_bridge(struct pci_dev *dev)
  1860	{
  1861		struct pci_dev *bridge;
  1862		int retval;
  1863	
> 1864		mutex_lock_nested(&dev->enable_mutex, pci_bridge_depth(dev));
  1865	
  1866		bridge = pci_upstream_bridge(dev);
  1867		if (bridge)
  1868			pci_enable_bridge(bridge);
  1869	
  1870		if (pci_is_enabled(dev)) {
  1871			if (!dev->is_busmaster)
  1872				pci_set_master(dev);
  1873			mutex_unlock(&dev->enable_mutex);
  1874			return;
  1875		}
  1876	
  1877		retval = pci_enable_device(dev);
  1878		if (retval)
  1879			pci_err(dev, "Error enabling bridge (%d), continuing\n",
  1880				retval);
  1881		pci_set_master(dev);
  1882		mutex_unlock(&dev->enable_mutex);
  1883	}
  1884	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38990 bytes --]