From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [PATCH 01/26] sandbox: serial: Move priv into a header file
Date: Mon, 21 Dec 2020 13:38:13 +0200 [thread overview]
Message-ID: <20201221113813.GK4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201219103947.1.I427a5dd4b053a0ee590f64f7a41ca4d3e6af26d8@changeid>
On Sat, Dec 19, 2020 at 10:39:53AM -0700, Simon Glass wrote:
> Move this struct into a header file so that dtoc can include it in its
> dt-platdata.c file.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> arch/sandbox/include/asm/serial.h | 30 ++++++++++++++++++++++++++++++
> drivers/serial/sandbox.c | 16 +---------------
> 2 files changed, 31 insertions(+), 15 deletions(-)
> create mode 100644 arch/sandbox/include/asm/serial.h
>
> diff --git a/arch/sandbox/include/asm/serial.h b/arch/sandbox/include/asm/serial.h
> new file mode 100644
> index 00000000000..bc82aebd0ea
> --- /dev/null
> +++ b/arch/sandbox/include/asm/serial.h
> @@ -0,0 +1,30 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * Copyright 2020 Google LLC
> + * Written by Simon Glass <sjg@chromium.org>
> + */
> +
> +#ifndef __asm_serial_h
> +#define __asm_serial_h
> +
> +#include <dt-structs.h>
> +
> +struct sandbox_serial_plat {
> +#if CONFIG_IS_ENABLED(OF_PLATDATA)
> + struct dtd_sandbox_serial dtplat;
> +#endif
> + int colour; /* Text colour to use for output, -1 for none */
> +};
> +
> +/**
> + * struct sandbox_serial_priv - Private data for this driver
> + *
> + * @buf: holds input characters available to be read by this driver
> + */
> +struct sandbox_serial_priv {
> + struct membuff buf;
> + char serial_buf[16];
> + bool start_of_line;
> +};
> +
> +#endif /* __asm_serial_h */
> diff --git a/drivers/serial/sandbox.c b/drivers/serial/sandbox.c
> index a05c56458b0..19368ba2560 100644
> --- a/drivers/serial/sandbox.c
> +++ b/drivers/serial/sandbox.c
> @@ -17,25 +17,11 @@
> #include <serial.h>
> #include <video.h>
> #include <linux/compiler.h>
> +#include <asm/serial.h>
> #include <asm/state.h>
>
> DECLARE_GLOBAL_DATA_PTR;
>
> -struct sandbox_serial_plat {
> - int colour; /* Text colour to use for output, -1 for none */
> -};
> -
> -/**
> - * struct sandbox_serial_priv - Private data for this driver
> - *
> - * @buf: holds input characters available to be read by this driver
> - */
> -struct sandbox_serial_priv {
> - struct membuff buf;
> - char serial_buf[16];
> - bool start_of_line;
> -};
> -
> /**
> * output_ansi_colour() - Output an ANSI colour code
> *
> --
> 2.29.2.684.gfbc64c5ab5-goog
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-12-21 11:38 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 17:39 [PATCH 00/26] dm: Preparation for enhanced of-platdata (part C) Simon Glass
2020-12-19 17:39 ` Simon Glass
2020-12-19 17:39 ` [PATCH 01/26] sandbox: serial: Move priv into a header file Simon Glass
2020-12-21 11:38 ` Andy Shevchenko [this message]
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:39 ` [PATCH 02/26] sandbox: i2c: " Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:39 ` [PATCH 03/26] sandbox: Add a compatible string for spltest Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:39 ` [PATCH 04/26] sandbox: Update dts files to reduce SPL size Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:39 ` [PATCH 05/26] x86: apl: Move priv/plat structs to headers Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:39 ` [PATCH 06/26] x86: Move priv/plat structs for intel_common " Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:39 ` [PATCH 07/26] x86: spl: Move priv/plat structs " Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 08/26] spi: Tidy up get/set of device node Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 09/26] spi: Tweak a few strange SPI NOR features for of-platdata Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 10/26] x86: apl: Use struct spi_nor instead of struct spi_flash Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 11/26] dm: core: Move priv/plat structs for simple_bus to headers Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 12/26] x86: sysreset: Move priv/plat structs " Simon Glass
2020-12-21 11:38 ` Andy Shevchenko
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 13/26] x86: apl: Adjust how the UART gets its platform data Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 14/26] x86: coral: Remove unwanted nodes from SPL/TPL Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 15/26] x86: Drop rtc from SPL Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 16/26] dm: core: Split out alloc code into a new function Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 17/26] dm: core: Rename sqq to seq_ Simon Glass
2020-12-21 11:41 ` Andy Shevchenko
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 18/26] dm: core: Access device flags through functions Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 19/26] dm: core: Rename device flags to indicate it is private Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 20/26] dm: core: Rename dev_has_of_node() to dev_has_ofnode() Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 21/26] dm: core: Use dev_has_ofnode() instead of dev_of_valid() Simon Glass
2020-12-21 11:41 ` Andy Shevchenko
2020-12-28 16:26 ` Simon Glass
2021-01-04 11:01 ` Patrick DELAUNAY
2020-12-19 17:40 ` [PATCH 22/26] dm: core: Access device ofnode through functions Simon Glass
2020-12-19 17:40 ` Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-28 16:26 ` Simon Glass
2021-01-04 13:02 ` Patrick DELAUNAY
2021-01-04 13:02 ` Patrick DELAUNAY
2021-01-07 12:36 ` Simon Glass
2021-01-07 12:36 ` Simon Glass
2020-12-19 17:40 ` [PATCH 23/26] dm: core: Rename device node to indicate it is private Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 24/26] dm: core: Split out scanning code to dm_scan() Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 25/26] dm: core: Allow the uclass list to move Simon Glass
2020-12-28 16:26 ` Simon Glass
2020-12-19 17:40 ` [PATCH 26/26] dm: core: Add logging when lists_bind_fdt() fails Simon Glass
2020-12-28 16:26 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201221113813.GK4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.