Re: [PATCH v2] tests/acceptance: Add a test with the Fedora 31 kernel and initrd

[Cornelia Huck <cohuck@redhat.com>]

On Fri, 18 Dec 2020 15:23:32 -0300
Willian Rampazzo <wrampazz@redhat.com> wrote:

> On 12/17/20 5:53 AM, Thomas Huth wrote:

> > +        # Hot-plug a virtio-crypto device and see whether it gets accepted
> > +        self.clear_guest_dmesg()  
> 
> Your previous patch "[PATCH 1/3] tests/acceptance: Extract the code to 
> clear dmesg and wait for CRW reports" defined the method as 
> "clear_guests_dmesg". After fixing this in the code:

Hm, I see clear_guest_dmesg in the code I have on my s390-next branch?

> 
> Tested-by: Willian Rampazzo <willianr@redhat.com>
> 
> > +        self.vm.command('object-add', qom_type='cryptodev-backend-builtin',
> > +                        id='cbe0')
> > +        self.vm.command('device_add', driver='virtio-crypto-ccw', id='crypdev0',
> > +                        cryptodev='cbe0')
> > +        exec_command_and_wait_for_pattern(self,
> > +                        'while ! (dmesg -c | grep Accelerator.device) ; do'
> > +                        ' sleep 1 ; done', 'Accelerator device is ready')
> > +        self.vm.command('device_del', id='crypdev0')
> > +        self.vm.command('object-del', id='cbe0')
> > +        exec_command_and_wait_for_pattern(self,
> > +                        'while ! (dmesg -c | grep Start.virtcrypto_remove) ; do'
> > +                        ' sleep 1 ; done', 'Start virtcrypto_remove.')
> >   
> 
> Reviewed-by: Willian Rampazzo <willianr@redhat.com>
>