From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/misc/habanalabs/common/firmware_if.c:371:18: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour
Date: Tue, 22 Dec 2020 16:22:26 +0800 [thread overview]
Message-ID: <202012221622.Af7DCPdT-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 7039 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 8653b778e454a7708847aeafe689bce07aeeb94e
commit: 7b16a15524d5db449cf5e529602610cdf04eddab habanalabs: fix up absolute include instructions
date: 5 months ago
:::::: branch date: 14 hours ago
:::::: commit date: 5 months ago
compiler: s390-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/misc/habanalabs/common/firmware_if.c:371:18: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
if (!(err_val & CPU_BOOT_ERR0_ENABLED))
^
--
>> drivers/misc/habanalabs/common/pci.c:115:5: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
PCI_CONFIG_ELBI_CTRL_WRITE);
^
drivers/misc/habanalabs/common/pci.c:120:13: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
if (val & PCI_CONFIG_ELBI_STS_MASK)
^
drivers/misc/habanalabs/common/pci.c:131:13: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
if ((val & PCI_CONFIG_ELBI_STS_MASK) == PCI_CONFIG_ELBI_STS_DONE)
^
drivers/misc/habanalabs/common/pci.c:139:14: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
if (!(val & PCI_CONFIG_ELBI_STS_MASK)) {
^
vim +371 drivers/misc/habanalabs/common/firmware_if.c
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 356
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 357 static void fw_read_errors(struct hl_device *hdev, u32 boot_err0_reg)
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 358 {
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 359 u32 err_val;
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 360
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 361 /* Some of the firmware status codes are deprecated in newer f/w
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 362 * versions. In those versions, the errors are reported
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 363 * in different registers. Therefore, we need to check those
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 364 * registers and print the exact errors. Moreover, there
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 365 * may be multiple errors, so we need to report on each error
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 366 * separately. Some of the error codes might indicate a state
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 367 * that is not an error per-se, but it is an error in production
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 368 * environment
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 369 */
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 370 err_val = RREG32(boot_err0_reg);
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 @371 if (!(err_val & CPU_BOOT_ERR0_ENABLED))
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 372 return;
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 373
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 374 if (err_val & CPU_BOOT_ERR0_DRAM_INIT_FAIL)
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 375 dev_err(hdev->dev,
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 376 "Device boot error - DRAM initialization failed\n");
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 377 if (err_val & CPU_BOOT_ERR0_FIT_CORRUPTED)
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 378 dev_err(hdev->dev, "Device boot error - FIT image corrupted\n");
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 379 if (err_val & CPU_BOOT_ERR0_TS_INIT_FAIL)
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 380 dev_err(hdev->dev,
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 381 "Device boot error - Thermal Sensor initialization failed\n");
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 382 if (err_val & CPU_BOOT_ERR0_DRAM_SKIPPED)
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 383 dev_warn(hdev->dev,
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 384 "Device boot warning - Skipped DRAM initialization\n");
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 385 if (err_val & CPU_BOOT_ERR0_BMC_WAIT_SKIPPED)
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 386 dev_warn(hdev->dev,
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 387 "Device boot error - Skipped waiting for BMC\n");
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 388 if (err_val & CPU_BOOT_ERR0_NIC_DATA_NOT_RDY)
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 389 dev_err(hdev->dev,
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 390 "Device boot error - Serdes data from BMC not available\n");
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 391 if (err_val & CPU_BOOT_ERR0_NIC_FW_FAIL)
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 392 dev_err(hdev->dev,
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 393 "Device boot error - NIC F/W initialization failed\n");
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 394 }
7e1c07dd3525097 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 395
:::::: The code at line 371 was first introduced by commit
:::::: 7e1c07dd35250971cd29c60c786ac676179eb7f9 habanalabs: unify and improve device cpu init
:::::: TO: Oded Gabbay <oded.gabbay@gmail.com>
:::::: CC: Oded Gabbay <oded.gabbay@gmail.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next reply other threads:[~2020-12-22 8:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 8:22 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-12-22 21:30 drivers/misc/habanalabs/common/firmware_if.c:371:18: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour kernel test robot
2020-12-22 13:38 kernel test robot
2020-12-22 12:58 kernel test robot
2020-12-22 7:46 kernel test robot
2020-12-22 7:13 kernel test robot
2020-12-22 5:34 kernel test robot
2020-12-22 1:32 kernel test robot
2020-12-22 1:18 kernel test robot
2020-08-10 23:42 kernel test robot
2020-08-10 23:42 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012221622.Af7DCPdT-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.