From: Oscar Salvador <osalvador@suse.de>
To: Muchun Song <songmuchun@bytedance.com>
Cc: corbet@lwn.net, mike.kravetz@oracle.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com,
dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, viro@zeniv.linux.org.uk,
akpm@linux-foundation.org, paulmck@kernel.org,
mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com,
rdunlap@infradead.org, oneukum@suse.com,
anshuman.khandual@arm.com, jroedel@suse.de,
almasrymina@google.com, rientjes@google.com, willy@infradead.org,
mhocko@suse.com, song.bao.hua@hisilicon.com, david@redhat.com,
naoya.horiguchi@nec.com, duanxiongchun@bytedance.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v11 10/11] mm/hugetlb: Gather discrete indexes of tail page
Date: Tue, 22 Dec 2020 17:29:52 +0100 [thread overview]
Message-ID: <20201222162948.GA31385@linux> (raw)
In-Reply-To: <20201222142440.28930-11-songmuchun@bytedance.com>
On Tue, Dec 22, 2020 at 10:24:39PM +0800, Muchun Song wrote:
> +#else
> +static inline void hwpoison_subpage_deliver(struct hstate *h, struct page *head)
> +{
> +}
> +
> +static inline void hwpoison_subpage_set(struct hstate *h, struct page *head,
> + struct page *page)
> +{
> + if (PageHWPoison(head) && page != head) {
> + /*
> + * Move PageHWPoison flag from head page to the raw error page,
> + * which makes any subpages rather than the error page reusable.
> + */
> + SetPageHWPoison(page);
> + ClearPageHWPoison(head);
> + }
> +}
> +#endif
Sorry, I guess I should have made a more clear statement.
This patch should really be about changing the numeric index to its symbolic
names, so the #ifdef handling of hwpoison_subpage_* should have been gone into
patch#6.
I will have a closer look later on though.
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2020-12-22 16:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 14:24 [PATCH v11 00/11] Free some vmemmap pages of HugeTLB page Muchun Song
2020-12-22 14:24 ` [PATCH v11 01/11] mm/memory_hotplug: Factor out bootmem core functions to bootmem_info.c Muchun Song
2020-12-22 14:24 ` [PATCH v11 02/11] mm/hugetlb: Introduce a new config HUGETLB_PAGE_FREE_VMEMMAP Muchun Song
2020-12-22 14:24 ` [PATCH v11 03/11] mm/hugetlb: Free the vmemmap pages associated with each HugeTLB page Muchun Song
2020-12-22 16:32 ` Oscar Salvador
2020-12-23 2:47 ` [External] " Muchun Song
2020-12-22 14:24 ` [PATCH v11 04/11] mm/hugetlb: Defer freeing of HugeTLB pages Muchun Song
2020-12-22 14:24 ` [PATCH v11 05/11] mm/hugetlb: Allocate the vmemmap pages associated with each HugeTLB page Muchun Song
2020-12-22 14:24 ` [PATCH v11 06/11] mm/hugetlb: Set the PageHWPoison to the raw error page Muchun Song
2020-12-22 14:24 ` [PATCH v11 07/11] mm/hugetlb: Flush work when dissolving a HugeTLB page Muchun Song
2020-12-22 14:24 ` [PATCH v11 08/11] mm/hugetlb: Add a kernel parameter hugetlb_free_vmemmap Muchun Song
2020-12-22 14:24 ` [PATCH v11 09/11] mm/hugetlb: Introduce nr_free_vmemmap_pages in the struct hstate Muchun Song
2020-12-22 14:24 ` [PATCH v11 10/11] mm/hugetlb: Gather discrete indexes of tail page Muchun Song
2020-12-22 16:29 ` Oscar Salvador [this message]
2020-12-23 2:46 ` [External] " Muchun Song
2020-12-22 14:24 ` [PATCH v11 11/11] mm/hugetlb: Optimize the code with the help of the compiler Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201222162948.GA31385@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=anshuman.khandual@arm.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=duanxiongchun@bytedance.com \
--cc=hpa@zytor.com \
--cc=jroedel@suse.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=mingo@redhat.com \
--cc=naoya.horiguchi@nec.com \
--cc=oneukum@suse.com \
--cc=paulmck@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=song.bao.hua@hisilicon.com \
--cc=songmuchun@bytedance.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.