From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05E6EC433DB for ; Tue, 22 Dec 2020 21:07:31 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C48021973 for ; Tue, 22 Dec 2020 21:07:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C48021973 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608671249; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=1JAeAfTeyO4c3JjT/l/kNb6NLzRgGd2UHD+46n5J+ws=; b=VqTqCwuTgiPtcGmieiJ/EiYvnKvsRGGFMSLGbSnr/DkPjkG3mlf7GhQDmwSZ/muazCZzgU +giI/s9JH0OithgnFVEpFHo//12gJ9aPDhoQPsGHcUB8sGU6mcWDqppCHETzZZbvHwwqvc CMHqUGlDMdrncntzYIo460mWWtGaT9U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-393-FNP4cse8MquQ5m-0-F_56A-1; Tue, 22 Dec 2020 16:07:26 -0500 X-MC-Unique: FNP4cse8MquQ5m-0-F_56A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 98D28107ACE4; Tue, 22 Dec 2020 21:07:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E80E05C728; Tue, 22 Dec 2020 21:07:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 34EA1180954D; Tue, 22 Dec 2020 21:07:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0BML6FuN001656 for ; Tue, 22 Dec 2020 16:06:15 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4AE0E60C69; Tue, 22 Dec 2020 21:06:15 +0000 (UTC) Received: from agk.fab.redhat.com (agk-dp.fab.redhat.com [10.33.15.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 130E060BF1; Tue, 22 Dec 2020 21:06:06 +0000 (UTC) Received: from agk by agk.fab.redhat.com with local (Exim 4.34) id 1kror6-0008DP-Kd; Tue, 22 Dec 2020 21:06:04 +0000 Date: Tue, 22 Dec 2020 21:06:04 +0000 From: Alasdair G Kergon To: Hannes Reinecke Message-ID: <20201222210604.GD29336@agk.fab.redhat.com> Mail-Followup-To: Hannes Reinecke , Mike Snitzer , Christoph Hellwig , linux-block@vger.kernel.org, dm-devel@redhat.com, Jens Axboe , Linux Kernel Mailing List , Alasdair G Kergon References: <20201222095056.7a5ac0a0@canb.auug.org.au> <20201222131528.GA29822@lst.de> <20201222145327.GC12885@redhat.com> <288d1c58-c0e2-9d6f-4816-48c66536fe8b@suse.de> Mime-Version: 1.0 In-Reply-To: <288d1c58-c0e2-9d6f-4816-48c66536fe8b@suse.de> User-Agent: Mutt/1.4.1i Organization: Red Hat UK Ltd. Registered in England and Wales, number 03798903. Registered Office: Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE. X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: dm-devel@redhat.com Cc: Jens Axboe , Mike Snitzer , Linux Kernel Mailing List , linux-block@vger.kernel.org, dm-devel@redhat.com, Christoph Hellwig , Alasdair G Kergon Subject: Re: [dm-devel] DM's filesystem lookup in dm_get_dev_t() [was: Re: linux-next: manual merge of the device-mapper tree with Linus' tree] X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Dec 22, 2020 at 06:24:09PM +0100, Hannes Reinecke wrote: > However, lookup_bdev() now always recurses into the filesystem, causing > multipath to stall in an all-paths-down scenario. I have not read the background about whatever the new problem is - I'm jumping in cold seeing this message - but from the very beginning of device-mapper we have strongly recommended that userspace supplies the block device in the form MAJOR:MINOR and all our own tools do that. We guarantee not to deadlock in these places when this is done. We also accept the device in the form of a path name as we know there are times when this is safe and convenient, but then we offer no guarantees - we place the responsibility upon userspace only to do this when it knows it is safe to do so i.e. no race and no deadlock. Alasdair -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87699C433DB for ; Tue, 22 Dec 2020 21:08:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 567BF221F9 for ; Tue, 22 Dec 2020 21:08:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727610AbgLVVHr (ORCPT ); Tue, 22 Dec 2020 16:07:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:40682 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725913AbgLVVHq (ORCPT ); Tue, 22 Dec 2020 16:07:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608671180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9bn1JYbMxk5cmELKh20sbfobuiV+1RVOI1Ppix+Ly8E=; b=EA95Rb9ALs8usdxB7URohzdLSMHf3JyoaWeP4KZPZwTfwThr1C6f6IWcGJNORlUvpHUu73 UE5ROQecf7QocWAOuImVxGVfGbwBuXSypczcOYSViMdAEgtLBZv4pBArl37oFEaiZSHgzE fwsyVecBZezGnCKKcXvxhtStA63RWE0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-F7SXmEoDNbii6xj-gw2fcA-1; Tue, 22 Dec 2020 16:06:16 -0500 X-MC-Unique: F7SXmEoDNbii6xj-gw2fcA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4C0151005504; Tue, 22 Dec 2020 21:06:15 +0000 (UTC) Received: from agk.fab.redhat.com (agk-dp.fab.redhat.com [10.33.15.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 130E060BF1; Tue, 22 Dec 2020 21:06:06 +0000 (UTC) Received: from agk by agk.fab.redhat.com with local (Exim 4.34) id 1kror6-0008DP-Kd; Tue, 22 Dec 2020 21:06:04 +0000 Date: Tue, 22 Dec 2020 21:06:04 +0000 From: Alasdair G Kergon To: Hannes Reinecke Cc: Mike Snitzer , Christoph Hellwig , linux-block@vger.kernel.org, dm-devel@redhat.com, Jens Axboe , Linux Kernel Mailing List , Alasdair G Kergon Subject: Re: [dm-devel] DM's filesystem lookup in dm_get_dev_t() [was: Re: linux-next: manual merge of the device-mapper tree with Linus' tree] Message-ID: <20201222210604.GD29336@agk.fab.redhat.com> Mail-Followup-To: Hannes Reinecke , Mike Snitzer , Christoph Hellwig , linux-block@vger.kernel.org, dm-devel@redhat.com, Jens Axboe , Linux Kernel Mailing List , Alasdair G Kergon References: <20201222095056.7a5ac0a0@canb.auug.org.au> <20201222131528.GA29822@lst.de> <20201222145327.GC12885@redhat.com> <288d1c58-c0e2-9d6f-4816-48c66536fe8b@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <288d1c58-c0e2-9d6f-4816-48c66536fe8b@suse.de> User-Agent: Mutt/1.4.1i Organization: Red Hat UK Ltd. Registered in England and Wales, number 03798903. Registered Office: Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE. X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Dec 22, 2020 at 06:24:09PM +0100, Hannes Reinecke wrote: > However, lookup_bdev() now always recurses into the filesystem, causing > multipath to stall in an all-paths-down scenario. I have not read the background about whatever the new problem is - I'm jumping in cold seeing this message - but from the very beginning of device-mapper we have strongly recommended that userspace supplies the block device in the form MAJOR:MINOR and all our own tools do that. We guarantee not to deadlock in these places when this is done. We also accept the device in the form of a path name as we know there are times when this is safe and convenient, but then we offer no guarantees - we place the responsibility upon userspace only to do this when it knows it is safe to do so i.e. no race and no deadlock. Alasdair