From: "Pavel Machek" <pavel@denx.de>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: cip-dev@lists.cip-project.org,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Pavel Machek <pavel@denx.de>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [cip-dev] [PATCH 4.4.y-cip] ARM: dts: iwg22d-sodimm: Fix dt nodes sorting
Date: Wed, 23 Dec 2020 01:13:10 +0100 [thread overview]
Message-ID: <20201223001310.GA13078@amd> (raw)
In-Reply-To: <20201222112714.24595-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
[-- Attachment #1.1: Type: text/plain, Size: 859 bytes --]
Hi!
> From: Biju Das <biju.das.jz@bp.renesas.com>
>
> commit 73aa5b7c941145b7a1a53f31b6a71dfe98007870 upstream.
>
> Some r8a7745-iwg22d-sodimm.dts device nodes are not sorted alphabetically.
> This patch fixes the sorting of nodes and also fixes a typo in the stmpe
> node.
I see why this is good idea for mainline, but do we need it in 4.4?
I guess it makes patch backporting easier, but maybe that can wait for
such backport?
> /* 3.25 MHz ADC clock speed */
> st,adc-freq = <1>;
> - /* ADC converstion time: 80 clocks */
> + /* ADC conversation time: 80 clocks */
> st,sample-time = <4>;
I believe this is wrong. Should be "conversion"?
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 420 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5973): https://lists.cip-project.org/g/cip-dev/message/5973
Mute This Topic: https://lists.cip-project.org/mt/79146851/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2020-12-23 0:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 11:27 [cip-dev] [PATCH 4.4.y-cip] ARM: dts: iwg22d-sodimm: Fix dt nodes sorting Lad Prabhakar
2020-12-22 13:09 ` Nobuhiro Iwamatsu
2020-12-23 0:13 ` Pavel Machek [this message]
2020-12-29 11:34 ` Lad Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201223001310.GA13078@amd \
--to=pavel@denx.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.