From: Stephen Hemminger <stephen@networkplumber.org>
To: dapengx.yu@intel.com
Cc: wenzhuo.lu@intel.com, beilei.xing@intel.com,
bernard.iremonger@intel.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: avoid exit without resource release
Date: Thu, 24 Dec 2020 19:03:17 -0800 [thread overview]
Message-ID: <20201224190317.4bac8b59@hermes.local> (raw)
In-Reply-To: <20201224035748.67012-1-dapengx.yu@intel.com>
On Thu, 24 Dec 2020 11:57:48 +0800
dapengx.yu@intel.com wrote:
> From: YU DAPENG <dapengx.yu@intel.com>
>
> In interactive mode, if testpmd exit by calling rte_exit without cmdline
> resource release, terminal will not echo keyboard input. So add code to
> just show error message, but not exit testpmd when unexpected happens
> on starting packet forwarding in interactive mode. User can type "quit"
> to exit testpmd later.
>
> Fixes: 5a8fb55c48ab ("app/testpmd: support unidirectional configuration")
> Cc: stable@dpdk.org
>
> Signed-off-by: YU DAPENG <dapengx.yu@intel.com>
Sounds like a more generic problem with rte_exit and librte_cmdline.
Would it better to fix it in librte_cmdline by adding an atexit() handler.
next prev parent reply other threads:[~2020-12-25 3:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 3:57 [dpdk-dev] [PATCH] app/testpmd: avoid exit without resource release dapengx.yu
2020-12-25 3:03 ` Stephen Hemminger [this message]
2020-12-25 5:09 ` Yu, DapengX
2021-01-15 3:28 ` Yu, DapengX
2021-01-15 5:50 ` Xing, Beilei
2021-01-15 6:05 ` Yu, DapengX
2021-01-15 9:21 ` Li, Xiaoyun
2021-01-18 11:47 ` Yu, DapengX
2021-01-25 3:29 ` [dpdk-dev] [PATCH v2] app/testpmd: avoid exit without terminal restore dapengx.yu
2021-01-26 6:33 ` Li, Xiaoyun
2021-01-26 7:13 ` Yu, DapengX
2021-01-26 7:44 ` Yu, DapengX
2021-01-26 8:24 ` Li, Xiaoyun
2021-01-29 10:46 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201224190317.4bac8b59@hermes.local \
--to=stephen@networkplumber.org \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dapengx.yu@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.