Re: [PATCH v7 1/5] counter: Internalize sysfs interface code

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5965 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <fc40ab7f4a38e80d86715daa5eaf744dd645a75b.1608935587.git.vilhelm.gray@gmail.com>
References: <fc40ab7f4a38e80d86715daa5eaf744dd645a75b.1608935587.git.vilhelm.gray@gmail.com>
TO: William Breathitt Gray <vilhelm.gray@gmail.com>

Hi William,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on next-20201223]
[cannot apply to stm32/stm32-next linux/master v5.10]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/William-Breathitt-Gray/Introduce-the-Counter-character-device-interface/20201226-082226
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 61d791365b72a89062fbbea69aa61479476da946
:::::: branch date: 18 hours ago
:::::: commit date: 18 hours ago
config: i386-randconfig-m021-20201226 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/counter/counter-sysfs.c:172 counter_comp_u32_show() error: uninitialized symbol 'err'.

Old smatch warnings:
drivers/counter/counter-sysfs.c:104 counter_comp_u8_show() error: uninitialized symbol 'err'.
drivers/counter/counter-sysfs.c:289 counter_comp_u64_show() error: uninitialized symbol 'err'.

vim +/err +172 drivers/counter/counter-sysfs.c

d2735d30323ad0d William Breathitt Gray 2020-12-25  147  
d2735d30323ad0d William Breathitt Gray 2020-12-25  148  static ssize_t counter_comp_u32_show(struct device *dev,
d2735d30323ad0d William Breathitt Gray 2020-12-25  149  				     struct device_attribute *attr, char *buf)
d2735d30323ad0d William Breathitt Gray 2020-12-25  150  {
d2735d30323ad0d William Breathitt Gray 2020-12-25  151  	const struct counter_attribute *const a = to_counter_attribute(attr);
d2735d30323ad0d William Breathitt Gray 2020-12-25  152  	struct counter_device *const counter = dev_get_drvdata(dev);
d2735d30323ad0d William Breathitt Gray 2020-12-25  153  	const struct counter_available *const avail = a->comp.priv;
d2735d30323ad0d William Breathitt Gray 2020-12-25  154  	int err;
d2735d30323ad0d William Breathitt Gray 2020-12-25  155  	u32 data = 0;
d2735d30323ad0d William Breathitt Gray 2020-12-25  156  
d2735d30323ad0d William Breathitt Gray 2020-12-25  157  	switch (a->scope) {
d2735d30323ad0d William Breathitt Gray 2020-12-25  158  	case COUNTER_SCOPE_DEVICE:
d2735d30323ad0d William Breathitt Gray 2020-12-25  159  		err = a->comp.device_u32_read(counter, &data);
d2735d30323ad0d William Breathitt Gray 2020-12-25  160  		break;
d2735d30323ad0d William Breathitt Gray 2020-12-25  161  	case COUNTER_SCOPE_SIGNAL:
d2735d30323ad0d William Breathitt Gray 2020-12-25  162  		err = a->comp.signal_u32_read(counter, a->parent, &data);
d2735d30323ad0d William Breathitt Gray 2020-12-25  163  		break;
d2735d30323ad0d William Breathitt Gray 2020-12-25  164  	case COUNTER_SCOPE_COUNT:
d2735d30323ad0d William Breathitt Gray 2020-12-25  165  		if (a->comp.type == COUNTER_COMP_SYNAPSE_ACTION)
d2735d30323ad0d William Breathitt Gray 2020-12-25  166  			err = a->comp.action_read(counter, a->parent,
d2735d30323ad0d William Breathitt Gray 2020-12-25  167  						  a->comp.priv, &data);
d2735d30323ad0d William Breathitt Gray 2020-12-25  168  		else
d2735d30323ad0d William Breathitt Gray 2020-12-25  169  			err = a->comp.count_u32_read(counter, a->parent, &data);
d2735d30323ad0d William Breathitt Gray 2020-12-25  170  		break;
d2735d30323ad0d William Breathitt Gray 2020-12-25  171  	}
d2735d30323ad0d William Breathitt Gray 2020-12-25 @172  	if (err < 0)
d2735d30323ad0d William Breathitt Gray 2020-12-25  173  		return err;
d2735d30323ad0d William Breathitt Gray 2020-12-25  174  
d2735d30323ad0d William Breathitt Gray 2020-12-25  175  	switch (a->comp.type) {
d2735d30323ad0d William Breathitt Gray 2020-12-25  176  	case COUNTER_COMP_FUNCTION:
d2735d30323ad0d William Breathitt Gray 2020-12-25  177  		return sprintf(buf, "%s\n", counter_function_str[data]);
d2735d30323ad0d William Breathitt Gray 2020-12-25  178  	case COUNTER_COMP_SIGNAL_LEVEL:
d2735d30323ad0d William Breathitt Gray 2020-12-25  179  		return sprintf(buf, "%s\n", counter_signal_value_str[data]);
d2735d30323ad0d William Breathitt Gray 2020-12-25  180  	case COUNTER_COMP_SYNAPSE_ACTION:
d2735d30323ad0d William Breathitt Gray 2020-12-25  181  		return sprintf(buf, "%s\n", counter_synapse_action_str[data]);
d2735d30323ad0d William Breathitt Gray 2020-12-25  182  	case COUNTER_COMP_ENUM:
d2735d30323ad0d William Breathitt Gray 2020-12-25  183  		return sprintf(buf, "%s\n", avail->strs[data]);
d2735d30323ad0d William Breathitt Gray 2020-12-25  184  	case COUNTER_COMP_COUNT_DIRECTION:
d2735d30323ad0d William Breathitt Gray 2020-12-25  185  		return sprintf(buf, "%s\n", counter_count_direction_str[data]);
d2735d30323ad0d William Breathitt Gray 2020-12-25  186  	case COUNTER_COMP_COUNT_MODE:
d2735d30323ad0d William Breathitt Gray 2020-12-25  187  		return sprintf(buf, "%s\n", counter_count_mode_str[data]);
d2735d30323ad0d William Breathitt Gray 2020-12-25  188  	default:
d2735d30323ad0d William Breathitt Gray 2020-12-25  189  		break;
d2735d30323ad0d William Breathitt Gray 2020-12-25  190  	}
d2735d30323ad0d William Breathitt Gray 2020-12-25  191  
d2735d30323ad0d William Breathitt Gray 2020-12-25  192  	return sprintf(buf, "%u\n", (unsigned int)data);
d2735d30323ad0d William Breathitt Gray 2020-12-25  193  }
d2735d30323ad0d William Breathitt Gray 2020-12-25  194  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37701 bytes --]