From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-comment-return-1598-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 528749841C5 for ; Sun, 27 Dec 2020 11:12:44 +0000 (UTC) Date: Sun, 27 Dec 2020 06:12:37 -0500 From: "Michael S. Tsirkin" Message-ID: <20201227061119-mutt-send-email-mst@kernel.org> References: <20201221223338.7b5a21e6.pasic@linux.ibm.com> <20201222075005.69d1cc6e.pasic@linux.ibm.com> <20201222131404.61e4a136.cohuck@redhat.com> <7da54d5b-0787-c78f-4b35-6a4f7ed2f5bf@redhat.com> <20201224055247.5f9ce79c.pasic@linux.ibm.com> <67271e1e-96ea-4b28-7449-cdb0641aff72@redhat.com> <20201225041811.33dbbd4b.pasic@linux.ibm.com> <88f1134c-e1ca-e8e7-2fa6-9d6e1ca68d79@redhat.com> MIME-Version: 1.0 In-Reply-To: <88f1134c-e1ca-e8e7-2fa6-9d6e1ca68d79@redhat.com> Subject: Re: [virtio-comment] [PATCH RFC] virtio: introduce VIRTIO_F_DEVICE_STOP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline To: Jason Wang Cc: Halil Pasic , Cornelia Huck , stefanha@redhat.com, virtio-comment@lists.oasis-open.org, eperezma@redhat.com, sgarzare@redhat.com List-ID: On Fri, Dec 25, 2020 at 02:45:28PM +0800, Jason Wang wrote: > > I tend to say, that from a perspective of the driver, all requests that > > are available, and not yet used, are in-flight. So we have to be very > > careful when wording this requirement, to avoid misunderstandings. I > > don't think the first RFC is good enough. I will think some more about > > this. > > > Yes, I agree. The problem is that the spec doesn't describe how device work, > so if we want to be more accurate, it might require some work not only for > stop but also for e.g reset (something like in flight has been used by the > spec in that case). You probably mean the DEVICE_NEEDS_RESET description, right? For example, the driver can't assume requests in flight will be completed if DEVICE_NEEDS_RESET is set, nor can it assume that they have not been completed. A good implementation will try to recover by issuing a reset. yes, DEVICE_NEEDS_RESET is unfortunately underspecified which likely is related to the fact it is not widely implemented. -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/