From: Jiri Olsa <jolsa@redhat.com>
To: Song Liu <songliubraving@fb.com>
Cc: linux-kernel@vger.kernel.org, acme@kernel.org,
peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, namhyung@kernel.org,
mark.rutland@arm.com, kernel-team@fb.com
Subject: Re: [PATCH v5 2/4] perf: support build BPF skeletons with perf
Date: Mon, 28 Dec 2020 13:55:54 +0100 [thread overview]
Message-ID: <20201228125554.GC450923@krava> (raw)
In-Reply-To: <20201215181412.1730974-3-songliubraving@fb.com>
On Tue, Dec 15, 2020 at 10:14:10AM -0800, Song Liu wrote:
SNIP
> HOSTCC ?= gcc
> HOSTLD ?= ld
> HOSTAR ?= ar
> +CLANG ?= clang
> +LLVM_STRIP ?= llvm-strip
>
> PKG_CONFIG = $(CROSS_COMPILE)pkg-config
> LLVM_CONFIG ?= llvm-config
> @@ -735,7 +739,8 @@ prepare: $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)common-cmds.h archheaders $(drm_ioc
> $(x86_arch_prctl_code_array) \
> $(rename_flags_array) \
> $(arch_errno_name_array) \
> - $(sync_file_range_arrays)
> + $(sync_file_range_arrays) \
> + bpf-skel
>
> $(OUTPUT)%.o: %.c prepare FORCE
> $(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=$(build-dir) $@
> @@ -1008,7 +1013,43 @@ config-clean:
> python-clean:
> $(python-clean)
>
> -clean:: $(LIBTRACEEVENT)-clean $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean $(LIBPERF)-clean config-clean fixdep-clean python-clean
> +SKEL_OUT := $(abspath $(OUTPUT)util/bpf_skel)
> +SKEL_TMP_OUT := $(abspath $(SKEL_OUT)/.tmp)
> +SKELETONS :=
> +
> +ifdef BUILD_BPF_SKEL
> +BPFTOOL := $(SKEL_TMP_OUT)/bpftool-bootstrap
I think this needs to be:
BPFTOOL := $(SKEL_TMP_OUT)/bootstrap/bpftool
otherwise it won't compile for me
jirka
next prev parent reply other threads:[~2020-12-28 12:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 18:14 [PATCH v5 0/4] Introduce perf-stat -b for BPF programs Song Liu
2020-12-15 18:14 ` [PATCH v5 1/4] bpftool: add Makefile target bootstrap Song Liu
2020-12-15 18:14 ` [PATCH v5 2/4] perf: support build BPF skeletons with perf Song Liu
2020-12-28 12:55 ` Jiri Olsa [this message]
2020-12-28 17:33 ` Song Liu
2020-12-15 18:14 ` [PATCH v5 3/4] perf-stat: enable counting events for BPF programs Song Liu
2020-12-15 18:14 ` [PATCH v5 4/4] perf-stat: add documentation for -b option Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201228125554.GC450923@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.