From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: Carsten Haitzler <carsten.haitzler@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Subject: Re: [PATCH] drm/komeda: use bitmap API to convert U32 to bitmap
Date: Mon, 28 Dec 2020 21:50:16 +0200 [thread overview]
Message-ID: <20201228195016.GD4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201228194343.88880-1-yury.norov@gmail.com>
On Mon, Dec 28, 2020 at 11:43:43AM -0800, Yury Norov wrote:
> The commit be3e477effba636ad25 ("drm/komeda: Fix bit
> check to import to value of proper type") fixes possible
> out-of-bound issue related to find_first_bit() usage, but
> does not address the endianness problem.
Hmm... Can you elaborate?
...
> u32 comp_mask)
> - unsigned long comp_mask_local = (unsigned long)comp_mask;
Here we convert u32 to unsigned long (LSB is kept LSB since it happens in
native endianess).
> - id = find_first_bit(&comp_mask_local, 32);
Here it takes an address to unsigned long and tries only lower 32 bits.
Are you telling that find_first_bit() has an issue?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-12-28 23:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 19:43 [PATCH] drm/komeda: use bitmap API to convert U32 to bitmap Yury Norov
2020-12-28 19:50 ` Andy Shevchenko [this message]
2020-12-28 20:10 ` Yury Norov
2020-12-29 12:22 ` Carsten Haitzler
2020-12-29 13:50 ` Andy Shevchenko
2020-12-29 18:09 ` Yury Norov
2020-12-29 18:27 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201228195016.GD4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=carsten.haitzler@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.