From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [saeed:net-next 14/98] net/ipv6/ip6_output.c:154 ip6_finish_output_gso_slowpath_drop() error: uninitialized symbol 'ret'.
Date: Tue, 29 Dec 2020 17:55:21 +0800 [thread overview]
Message-ID: <202012291701.iiSNjPwz-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3558 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Aya Levin <ayal@nvidia.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git net-next
head: 5d0f806c7608fe61c73b31b28411ebb94b962ebf
commit: d1521c0603f22c6702c63c9354e80cd94d6c7dc6 [14/98] net: ipv6: Validate GSO SKB before finish IPv6 processing
:::::: branch date: 10 hours ago
:::::: commit date: 19 hours ago
config: x86_64-randconfig-m001-20201229 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
net/ipv6/ip6_output.c:154 ip6_finish_output_gso_slowpath_drop() error: uninitialized symbol 'ret'.
Old smatch warnings:
net/ipv6/ip6_output.c:158 ip6_finish_output_gso_slowpath_drop() error: uninitialized symbol 'ret'.
net/ipv6/ip6_output.c:291 ip6_xmit() error: we previously assumed 'np' could be null (see line 285)
vim +/ret +154 net/ipv6/ip6_output.c
^1da177e4c3f415 Linus Torvalds 2005-04-16 127
d1521c0603f22c6 Aya Levin 2020-12-16 128 static int
d1521c0603f22c6 Aya Levin 2020-12-16 129 ip6_finish_output_gso_slowpath_drop(struct net *net, struct sock *sk,
d1521c0603f22c6 Aya Levin 2020-12-16 130 struct sk_buff *skb, unsigned int mtu)
d1521c0603f22c6 Aya Levin 2020-12-16 131 {
d1521c0603f22c6 Aya Levin 2020-12-16 132 struct sk_buff *segs, *nskb;
d1521c0603f22c6 Aya Levin 2020-12-16 133 netdev_features_t features;
d1521c0603f22c6 Aya Levin 2020-12-16 134 int ret;
d1521c0603f22c6 Aya Levin 2020-12-16 135
d1521c0603f22c6 Aya Levin 2020-12-16 136 /* Please see corresponding comment in ip_finish_output_gso
d1521c0603f22c6 Aya Levin 2020-12-16 137 * describing the cases where GSO segment length exceeds the
d1521c0603f22c6 Aya Levin 2020-12-16 138 * egress MTU.
d1521c0603f22c6 Aya Levin 2020-12-16 139 */
d1521c0603f22c6 Aya Levin 2020-12-16 140 features = netif_skb_features(skb);
d1521c0603f22c6 Aya Levin 2020-12-16 141 segs = skb_gso_segment(skb, features & ~NETIF_F_GSO_MASK);
d1521c0603f22c6 Aya Levin 2020-12-16 142 if (IS_ERR_OR_NULL(segs)) {
d1521c0603f22c6 Aya Levin 2020-12-16 143 kfree_skb(skb);
d1521c0603f22c6 Aya Levin 2020-12-16 144 return -ENOMEM;
d1521c0603f22c6 Aya Levin 2020-12-16 145 }
d1521c0603f22c6 Aya Levin 2020-12-16 146
d1521c0603f22c6 Aya Levin 2020-12-16 147 consume_skb(skb);
d1521c0603f22c6 Aya Levin 2020-12-16 148
d1521c0603f22c6 Aya Levin 2020-12-16 149 skb_list_walk_safe(segs, segs, nskb) {
d1521c0603f22c6 Aya Levin 2020-12-16 150 int err;
d1521c0603f22c6 Aya Levin 2020-12-16 151
d1521c0603f22c6 Aya Levin 2020-12-16 152 skb_mark_not_on_list(segs);
d1521c0603f22c6 Aya Levin 2020-12-16 153 err = ip6_fragment(net, sk, segs, ip6_finish_output2);
d1521c0603f22c6 Aya Levin 2020-12-16 @154 if (err && ret == 0)
d1521c0603f22c6 Aya Levin 2020-12-16 155 ret = err;
d1521c0603f22c6 Aya Levin 2020-12-16 156 }
d1521c0603f22c6 Aya Levin 2020-12-16 157
d1521c0603f22c6 Aya Levin 2020-12-16 158 return ret;
d1521c0603f22c6 Aya Levin 2020-12-16 159 }
d1521c0603f22c6 Aya Levin 2020-12-16 160
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39282 bytes --]
next reply other threads:[~2020-12-29 9:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 9:55 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-05 12:18 [saeed:net-next 14/98] net/ipv6/ip6_output.c:154 ip6_finish_output_gso_slowpath_drop() error: uninitialized symbol 'ret' Dan Carpenter
2021-01-05 12:18 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012291701.iiSNjPwz-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.