From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB872C433DB for ; Wed, 30 Dec 2020 07:02:58 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 340AD20795 for ; Wed, 30 Dec 2020 07:02:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 340AD20795 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id B2AEC20467; Wed, 30 Dec 2020 07:02:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wYJLIVzcxKMk; Wed, 30 Dec 2020 07:02:56 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 653EE20410; Wed, 30 Dec 2020 07:02:55 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 476B9C0893; Wed, 30 Dec 2020 07:02:55 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7D110C0174 for ; Wed, 30 Dec 2020 07:02:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 626798717D for ; Wed, 30 Dec 2020 07:02:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T9Nd+MWQYNct for ; Wed, 30 Dec 2020 07:02:51 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by hemlock.osuosl.org (Postfix) with ESMTPS id C6D4D8717B for ; Wed, 30 Dec 2020 07:02:51 +0000 (UTC) Received: from zn.tnic (p200300ec2f0ae90058345bc89b9c20d2.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:e900:5834:5bc8:9b9c:20d2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E357E1EC04F0; Wed, 30 Dec 2020 08:02:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1609311768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=IVIq9v7uhd13qBpMQD16SmyiUO8UUvqpILGYkZ47HJo=; b=jq3k8zvDtJx6/tM/0+ZBgmlGDufmiW5hdO4HCuUJymq1D4Rabnx9CJMwz/OkGeCrPTJqqq dQVpIuosWm5FRr4E5snOgvGaJsrqLzdIgV0akYeADZppnBBQczJSwEZ8awF8gGCFXStV3q UiRy1KBwaTCCRMS6Imljj6Doo4kzQFw= Date: Wed, 30 Dec 2020 08:02:44 +0100 From: Borislav Petkov To: Zhenzhong Duan Subject: Re: [PATCH] x86/iommu: Fix two minimal issues in check_iommu_entries() Message-ID: <20201230070244.GA22022@zn.tnic> References: <20201223062412.343-1-zhenzhong.duan@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201223062412.343-1-zhenzhong.duan@gmail.com> Cc: will@kernel.org, konrad.wilk@oracle.com, dwmw2@infradead.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, mingo@redhat.com, joe@perches.com, tglx@linutronix.de, zhongjiang@huawei.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, Dec 23, 2020 at 02:24:12PM +0800, Zhenzhong Duan wrote: > check_iommu_entries() checks for cyclic dependency in iommu entries > and fixes the cyclic dependency by setting x->depend to NULL. But > this repairing isn't correct if q is in front of p, there will be > "EXECUTION ORDER INVALID!" report following. Fix it by NULLing > whichever in the front. When does "q is in front of p" happen? How does it happen? > The second issue is about the report of exectuion order reverse, > the order is reversed incorrectly in the report, fix it. I have no clue what that means. Plese structure your commit message something like this: Problem is A. It happens because of B. Fix it by doing C. (Potentially do D). For more detailed info, see Documentation/process/submitting-patches.rst, Section "2) Describe your changes". Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88365C433DB for ; Wed, 30 Dec 2020 07:03:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F9AD21973 for ; Wed, 30 Dec 2020 07:03:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726434AbgL3HD3 (ORCPT ); Wed, 30 Dec 2020 02:03:29 -0500 Received: from mail.skyhub.de ([5.9.137.197]:53098 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726198AbgL3HD3 (ORCPT ); Wed, 30 Dec 2020 02:03:29 -0500 Received: from zn.tnic (p200300ec2f0ae90058345bc89b9c20d2.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:e900:5834:5bc8:9b9c:20d2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E357E1EC04F0; Wed, 30 Dec 2020 08:02:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1609311768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=IVIq9v7uhd13qBpMQD16SmyiUO8UUvqpILGYkZ47HJo=; b=jq3k8zvDtJx6/tM/0+ZBgmlGDufmiW5hdO4HCuUJymq1D4Rabnx9CJMwz/OkGeCrPTJqqq dQVpIuosWm5FRr4E5snOgvGaJsrqLzdIgV0akYeADZppnBBQczJSwEZ8awF8gGCFXStV3q UiRy1KBwaTCCRMS6Imljj6Doo4kzQFw= Date: Wed, 30 Dec 2020 08:02:44 +0100 From: Borislav Petkov To: Zhenzhong Duan Cc: linux-kernel@vger.kernel.org, zhongjiang@huawei.com, joe@perches.com, konrad.wilk@oracle.com, tglx@linutronix.de, mingo@redhat.com, iommu@lists.linux-foundation.org, dwmw2@infradead.org, baolu.lu@linux.intel.com, joro@8bytes.org, will@kernel.org Subject: Re: [PATCH] x86/iommu: Fix two minimal issues in check_iommu_entries() Message-ID: <20201230070244.GA22022@zn.tnic> References: <20201223062412.343-1-zhenzhong.duan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201223062412.343-1-zhenzhong.duan@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 23, 2020 at 02:24:12PM +0800, Zhenzhong Duan wrote: > check_iommu_entries() checks for cyclic dependency in iommu entries > and fixes the cyclic dependency by setting x->depend to NULL. But > this repairing isn't correct if q is in front of p, there will be > "EXECUTION ORDER INVALID!" report following. Fix it by NULLing > whichever in the front. When does "q is in front of p" happen? How does it happen? > The second issue is about the report of exectuion order reverse, > the order is reversed incorrectly in the report, fix it. I have no clue what that means. Plese structure your commit message something like this: Problem is A. It happens because of B. Fix it by doing C. (Potentially do D). For more detailed info, see Documentation/process/submitting-patches.rst, Section "2) Describe your changes". Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette