All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minwoo Im <minwoo.im.dev@gmail.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
	Christoph Hellwig <hch@lst.de>,
	"Linux-nvme@lists.infradead.org" <Linux-nvme@lists.infradead.org>,
	Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH] nvme: unexport internal function symbols
Date: Wed, 30 Dec 2020 20:10:30 +0900	[thread overview]
Message-ID: <20201230111030.GA7917@localhost.localdomain> (raw)
In-Reply-To: <BYAPR04MB496508D70A0F3121191C0C2886D70@BYAPR04MB4965.namprd04.prod.outlook.com>

Hello,

On 20-12-30 07:10:49, Chaitanya Kulkarni wrote:
> On 12/27/20 2:46 AM, Minwoo Im wrote:
> > Unexport symbols not taken from other side.  This patch also make those
> > two functions as static functions:
> >
> >   nvme_reset_ctrl_sync
> >   nvme_alloc_request_qid
> >
> > This patch has no functional changes.
> change the commit log to :-
> 
> 
> There are no callers for nvme_reset_ctrl_sync() and
> nvme_alloc_request_qid()so that we keep the symbols exported.
> 
> Unexport those functions, mark them static and update the headerfile
> respectively.

Thanks for your review!

I think I should have written some of reasons why symbols are removed.
Please let me prepare V2 patch with comment updated.

Thanks,

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

      reply	other threads:[~2020-12-30 11:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-27 10:38 [PATCH] nvme: unexport internal function symbols Minwoo Im
2020-12-30  7:10 ` Chaitanya Kulkarni
2020-12-30 11:10   ` Minwoo Im [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201230111030.GA7917@localhost.localdomain \
    --to=minwoo.im.dev@gmail.com \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=Linux-nvme@lists.infradead.org \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.