All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org,
	"Benoît Cousson" <bcousson@baylibre.com>,
	devicetree@vger.kernel.org,
	"Carl Philipp Klemm" <philipp@uvos.xyz>,
	"Merlijn Wajer" <merlijn@wizzup.org>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Eduardo Valentin" <edubezval@gmail.com>,
	"Peter Ujfalusi" <peter.ujfalusi@gmail.com>
Subject: Re: [PATCH 3/3] ARM: dts: motorola-mapphone: Add 1.2GHz OPP
Date: Thu, 31 Dec 2020 10:43:15 +0100	[thread overview]
Message-ID: <20201231094315.GB22962@amd> (raw)
In-Reply-To: <20201230084232.19221-3-tony@atomide.com>

[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]

Hi!

> From: Carl Philipp Klemm <philipp@uvos.xyz>
> 
> The omap4430 HS HIGH performance devces support 1.2GHz opp, lower speed
> variants do not. However for mapphone devices Motorola seems to have
> decided that this does not really matter for the SoC variants they have
> tested to use, and decided to clock all devices, including the ones with
> STANDARD performance chips at 1.2GHz upon release of the 3.0.8 vendor
> kernel shiped with Android 4.0. Therefore it seems safe to do the same,
> but let's only do it for Motorola devices as the others have not been
> tested.
> 
> Note that we prevent overheating with the passive cooling device
> cpu_alert0 configured in the dts file that starts lowering the speed as
> needed.
> 
> This also removes the "failed to find current OPP for freq 1200000000"
> warning.

> +&cpu0 {
> +        /*
> +	 * Note that the 1.2GiHz mode is enabled for all SoC variants for
> +	 * the Motorola Android Linux v3.0.8 based kernel.
> +	 */

I'm pretty sure it is GHz, not GiHz.

> +        operating-points = <
> +	        /* kHz    uV */
> +	        300000  1025000
> +	        600000  1200000
> +	        800000  1313000
> +	        1008000 1375000
> +		1200000 1375000
> +        >;

Is it intended to be 1.008GHz, or is it a typo?

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2020-12-31  9:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-30  8:42 [PATCH 1/3] ARM: dts: Configure missing thermal interrupt for 4430 Tony Lindgren
2020-12-30  8:42 ` [PATCH 2/3] ARM: dts: motorola-mapphone: Configure lower temperature passive cooling Tony Lindgren
2020-12-31 14:33   ` Pavel Machek
2020-12-31 18:53   ` Pavel Machek
2020-12-30  8:42 ` [PATCH 3/3] ARM: dts: motorola-mapphone: Add 1.2GHz OPP Tony Lindgren
2020-12-31  9:43   ` Pavel Machek [this message]
2021-01-01  6:06     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201231094315.GB22962@amd \
    --to=pavel@ucw.cz \
    --cc=bcousson@baylibre.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=edubezval@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=merlijn@wizzup.org \
    --cc=peter.ujfalusi@gmail.com \
    --cc=philipp@uvos.xyz \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.