From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>
Cc: dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [PATCH v2] ip_pipeline: add Python script file for creating visual diagram of IP pipeline config file
Date: Mon, 11 Jul 2016 17:29:57 +0200 [thread overview]
Message-ID: <2020300.RGHe2OjfZK@xps13> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2025885B5@IRSMSX103.ger.corp.intel.com>
> > This commit adds Python script for generating diagram of the application
> > configuration file. This script requires graphviz package to be installed
> > on the machine. The input config file is translated to an output file in
> > DOT syntax, which is then used to create the image file using graphviz.
> >
> > To run the script, following command is used;
> >
> > ./diagram-generator.py -f <input configuration file>
> >
> > Some optional arguments are as follows:
> > -h, --help show this help message and exit
> >
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>
>
> The subject line is too long:
>
> $ scripts/check-git-log.sh
> Headline too long:
> ip_pipeline: add Python script file for creating visual diagram of IP pipeline config file
>
> I would suggest something like:
>
> ip_pipeline: add script for creating config diagrams
or
examples/ip_pipeline: add config diagram generator
> The code looks good though, so:
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied, thanks
This example become more and more complex...
prev parent reply other threads:[~2016-07-11 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 17:50 [PATCH] ip_pipeline: add Python script file for creating visual diagram of IP pipeline config file Jasvinder Singh
2016-06-27 9:11 ` Mcnamara, John
2016-06-28 16:22 ` [PATCH v2] " Jasvinder Singh
2016-06-28 16:58 ` Mcnamara, John
2016-07-11 15:29 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2020300.RGHe2OjfZK@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.