All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Nick Piggin <npiggin@suse.de>
Cc: dhowells@redhat.com, viro@ZenIV.linux.org.uk,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] Add a dentry op to handle automounting rather than abusing follow_link
Date: Thu, 22 Jul 2010 16:33:13 +0100	[thread overview]
Message-ID: <20204.1279812793@redhat.com> (raw)
In-Reply-To: <20100722145738.GA5752@amd>

Nick Piggin <npiggin@suse.de> wrote:

> I think you have it the wrong way around. If you wanted to call the
> automount code, you would have incremented d_mounted.

Why?  d_mounted indicates how many things are mounted on a dentry, doesn't it?
Before the automounter is invoked there isn't anything mounted there.

> Those that don't care wouldn't set ->follow_mount though.  Following a mount
> is a fairly heavy operation already, it does take a global lock (before vfs
> scalability patches, anyway).

I wonder if we could do it with a lock on vfsmount instead and use mnt_mounts
to find it.

> I like the flexibility of doing one's own ->follow_mount, although Al might
> object to allowing filesystems to follow mounts in ways that are not
> published to the core namespace structures.

But why would you want to delegate mountpoint traversal to the filesystem?

David

  reply	other threads:[~2010-07-22 15:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-13 21:55 [RFC][PATCH] Add a dentry op to handle automounting rather than abusing follow_link David Howells
2010-07-13 22:48 ` [RFC][PATCH] xstat: Add an AT_NO_AUTOMOUNT flag to suppress terminal automount David Howells
2010-07-22  4:15 ` [RFC][PATCH] Add a dentry op to handle automounting rather than abusing follow_link Nick Piggin
2010-07-22 12:36   ` David Howells
2010-07-22 14:57     ` Nick Piggin
2010-07-22 15:33       ` David Howells [this message]
2010-07-22 16:04         ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20204.1279812793@redhat.com \
    --to=dhowells@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.