From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7238897183929179811==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings Date: Fri, 01 Jan 2021 17:01:41 +0800 Message-ID: <20210101090141.GA45434@9b9e2a4d9fcb> In-Reply-To: <202101011714.Npqgu1JQ-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============7238897183929179811== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Denis Efremov CC: Julia Lawall CC: Ike Panhc CC: Darren Hart CC: Andy Shevchenko CC: platform-driver-x86(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/platform/x86/ideapad-laptop.c:522:60-61: WARNING opportunity for ko= bj_to_dev() Use kobj_to_dev() instead of container_of() Generated by: scripts/coccinelle/api/kobj_to_dev.cocci Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") CC: Denis Efremov Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: f6e1ea19649216156576aeafa784e3b4cee45549 commit: a2fc3718bc22e85378085568ecc5765fb28cabce coccinelle: api: add kobj_= to_dev.cocci script :::::: branch date: 2 days ago :::::: commit date: 4 months ago Please take the patch only if it's a positive warning. Thanks! ideapad-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/platform/x86/ideapad-laptop.c +++ b/drivers/platform/x86/ideapad-laptop.c @@ -519,7 +519,7 @@ static umode_t ideapad_is_visible(struct struct attribute *attr, int idx) { - struct device *dev =3D container_of(kobj, struct device, kobj); + struct device *dev =3D kobj_to_dev(kobj); struct ideapad_private *priv =3D dev_get_drvdata(dev); bool supported; =20 --===============7238897183929179811==--