All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/openblas: allow disabling multithreading
Date: Sat, 2 Jan 2021 17:34:37 +0100	[thread overview]
Message-ID: <20210102173437.3bc0698f@windsurf> (raw)
In-Reply-To: <20201202145024.13436-1-patrickdepinguin@gmail.com>

Hello Thomas,

On Wed,  2 Dec 2020 15:50:24 +0100
Thomas De Schampheleire <patrickdepinguin@gmail.com> wrote:

> +config BR2_PACKAGE_OPENBLAS_USE_THREAD
> +	bool "use multithreading"
> +	default y
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !BR2_STATIC_LIBS
> +	help
> +	  Tell OpenBLAS to use multithreading, by passing USE_THREAD=1.
> +
> +config BR2_PACKAGE_OPENBLAS_USE_LOCKING
> +	bool "use locking"
> +	default y
> +	depends on BR2_TOOLCHAIN_HAS_THREADS

Should this instead be:

	depends on !BR2_PACKAGE_OPENBLAS_USE_THREAD

indeed, as you're explaining in the help text, when USE_THREAD=1, the
USE_LOCKING option has no effect, as it is forcefully enabled.

And perhaps drop the "default y" ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2021-01-02 16:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02 14:50 [Buildroot] [PATCH] package/openblas: allow disabling multithreading Thomas De Schampheleire
2021-01-02 16:34 ` Thomas Petazzoni [this message]
2021-01-05 14:19   ` Thomas De Schampheleire
2021-01-05 14:51     ` Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2020-08-04 13:37 Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210102173437.3bc0698f@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.