From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH v1] efi: Don't use knowledge about efi_guid_t internals
Date: Sat, 2 Jan 2021 23:36:59 +0200 [thread overview]
Message-ID: <20210102213659.GP4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201015115028.81857-1-andriy.shevchenko@linux.intel.com>
On Thu, Oct 15, 2020 at 02:50:28PM +0300, Andy Shevchenko wrote:
> When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather
> its internal members.
Any comment on this?
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> security/integrity/platform_certs/efi_parser.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/platform_certs/efi_parser.c b/security/integrity/platform_certs/efi_parser.c
> index 18f01f36fe6a..d98260f8402a 100644
> --- a/security/integrity/platform_certs/efi_parser.c
> +++ b/security/integrity/platform_certs/efi_parser.c
> @@ -55,7 +55,7 @@ int __init parse_efi_signature_list(
> memcpy(&list, data, sizeof(list));
> pr_devel("LIST[%04x] guid=%pUl ls=%x hs=%x ss=%x\n",
> offs,
> - list.signature_type.b, list.signature_list_size,
> + &list.signature_type, list.signature_list_size,
> list.signature_header_size, list.signature_size);
>
> lsize = list.signature_list_size;
> --
> 2.28.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-01-02 21:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 11:50 [PATCH v1] efi: Don't use knowledge about efi_guid_t internals Andy Shevchenko
2021-01-02 21:36 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-09 16:45 Andy Shevchenko
2021-02-09 16:51 ` Ard Biesheuvel
2021-06-07 17:11 ` Andy Shevchenko
2021-06-10 15:05 ` Ard Biesheuvel
2021-08-26 15:08 ` Andy Shevchenko
2021-08-26 16:37 ` Ard Biesheuvel
2021-08-26 20:27 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210102213659.GP4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jmorris@namei.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.