From: Rob Herring <robh@kernel.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 1/1] dt-bindings: adc-keys.txt: clarify description
Date: Sun, 3 Jan 2021 09:38:06 -0700 [thread overview]
Message-ID: <20210103163806.GA4008983@robh.at.kernel.org> (raw)
In-Reply-To: <20201222110815.24121-1-xypron.glpk@gmx.de>
On Tue, 22 Dec 2020 12:08:15 +0100, Heinrich Schuchardt wrote:
> The current description of ADC keys is not precise enough.
>
> "when this key is pressed" leaves it open if a key is considered pressed
> below or above the threshold. This has led to confusion:
> drivers/input/keyboard/adc-keys.c ignores the meaning of thresholds and
> sets the key that is closest to press-threshold-microvolt.
>
> This patch nails down the definitions and provides an interpretation of the
> supplied example.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> I know that this file needs to be converted to YAML. But lets first get the
> text right.
> ---
> .../devicetree/bindings/input/adc-keys.txt | 22 +++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2021-01-03 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 11:08 [PATCH 1/1] dt-bindings: adc-keys.txt: clarify description Heinrich Schuchardt
2021-01-03 16:38 ` Rob Herring [this message]
2021-01-05 22:21 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210103163806.GA4008983@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.